hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-20295) Remove !isNumber check after failed constant interpretation
Date Tue, 05 Feb 2019 08:53:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-20295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16760590#comment-16760590
] 

Hive QA commented on HIVE-20295:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12957595/HIVE-20295.09.patch

{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.

{color:green}SUCCESS:{color} +1 due to 15771 tests passed

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/15940/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/15940/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-15940/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12957595 - PreCommit-HIVE-Build

> Remove !isNumber check after failed constant interpretation
> -----------------------------------------------------------
>
>                 Key: HIVE-20295
>                 URL: https://issues.apache.org/jira/browse/HIVE-20295
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Zoltan Haindrich
>            Assignee: Ivan Suller
>            Priority: Major
>         Attachments: HIVE-20295.01.patch, HIVE-20295.02.patch, HIVE-20295.03.patch, HIVE-20295.04.patch,
HIVE-20295.05.patch, HIVE-20295.06.patch, HIVE-20295.07.patch, HIVE-20295.08.patch, HIVE-20295.09.patch
>
>
> During constant interpretation; if the number can't be parsed - it might be possible
that the comparsion is out of range for the type in question - in which case it could be removed.
> https://github.com/apache/hive/blob/2cabb8da150b8fb980223fbd6c2c93b842ca3ee5/ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java#L1163



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message