hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Peter Vary (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-20849) Review of ConstantPropagateProcFactory
Date Tue, 05 Feb 2019 09:50:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-20849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16760637#comment-16760637
] 

Peter Vary commented on HIVE-20849:
-----------------------------------

[~belugabehr]: Quick questions:
* Why have you not changed the following lines of log formatting?:
{code}
LOG.error("Reverse look up of column " + desc + " error!");
...
LOG.error("Cannot resolve " + desc.getTabAlias() + "." + desc.getColumn());
{code}
* Have you validated that we do not try to change the Maps where you used {{Collections.emptyMap()}}
to set empty ones, or we just rely on tests for the validation of this?

Thanks,
Peter

> Review of ConstantPropagateProcFactory
> --------------------------------------
>
>                 Key: HIVE-20849
>                 URL: https://issues.apache.org/jira/browse/HIVE-20849
>             Project: Hive
>          Issue Type: Improvement
>          Components: Logical Optimizer
>    Affects Versions: 3.1.0, 4.0.0
>            Reporter: BELUGA BEHR
>            Assignee: BELUGA BEHR
>            Priority: Minor
>         Attachments: HIVE-20849.1.patch, HIVE-20849.1.patch, HIVE-20849.2.patch, HIVE-20849.3.patch,
HIVE-20849.4.patch, HIVE-20849.5.patch, HIVE-20849.6.patch
>
>
> I was looking at this class because it blasts a lot of useless (to an admin) information
to the logs.  Especially if the table has a lot of columns, I see big blocks of logging that
are meaningless to me.  I request that the logging is toned down to debug, and some other
improvements to the code.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message