hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-21214) MoveTask : Use attemptId instead of file size for deduplication of files compareTempOrDuplicateFiles()
Date Tue, 05 Feb 2019 15:37:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-21214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16760939#comment-16760939
] 

Hive QA commented on HIVE-21214:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12957608/HIVE-21214.1.patch

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:green}SUCCESS:{color} +1 due to 15729 tests passed

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/15944/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/15944/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-15944/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12957608 - PreCommit-HIVE-Build

> MoveTask : Use attemptId instead of file size for deduplication of files compareTempOrDuplicateFiles()
> ------------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-21214
>                 URL: https://issues.apache.org/jira/browse/HIVE-21214
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Deepak Jaiswal
>            Assignee: Deepak Jaiswal
>            Priority: Major
>         Attachments: HIVE-21214.1.patch
>
>
> For a given task, if there is more than one attempt then deduplication logic kicks in.
> {noformat}
> Utilities.compareTempOrDuplicateFiles(){noformat}
> The logic uses file size and picks the one with largest size. This logic is very fragile.
> ideally, it should pick the successful attempt's file.
> However, a simpler solution is to pick the newest attempt and also checking the file
size for the newest attempt is the largest.
> If not, throw an exception.
>  
> cc [~gopalv] [~thejas] [~jdere] [~ekoifman]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message