hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-21221) Make HS2 and LLAP consistent - Bring up LLAP WebUI in test mode if WebUI port is configured
Date Wed, 06 Feb 2019 05:30:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-21221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16761498#comment-16761498
] 

Hive QA commented on HIVE-21221:
--------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  0s{color} |
{color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  7m 38s{color}
| {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 19s{color} |
{color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 12s{color}
| {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 38s{color} | {color:blue}
llap-server in master has 81 extant Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 13s{color} |
{color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 19s{color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 19s{color} |
{color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 19s{color} | {color:green}
the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 11s{color} | {color:red}
llap-server: The patch generated 4 new + 36 unchanged - 0 fixed = 40 total (was 36) {color}
|
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m  0s{color}
| {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  0m 46s{color} | {color:red}
llap-server generated 1 new + 81 unchanged - 0 fixed = 82 total (was 81) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 13s{color} |
{color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red}  0m 13s{color} | {color:red}
The patch generated 1 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 11m 27s{color} | {color:black}
{color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:llap-server |
|  |  Boxing/unboxing to parse a primitive new org.apache.hadoop.hive.llap.daemon.impl.LlapDaemon(Configuration,
int, long, boolean, boolean, long, String[], int, int, int, int, String)  At LlapDaemon.java:new
org.apache.hadoop.hive.llap.daemon.impl.LlapDaemon(Configuration, int, long, boolean, boolean,
long, String[], int, int, int, int, String)  At LlapDaemon.java:[line 319] |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03)
x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-15958/dev-support/hive-personality.sh
|
| git revision | master / 313e49f |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-15958/yetus/diff-checkstyle-llap-server.txt
|
| findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-15958/yetus/new-findbugs-llap-server.html
|
| asflicense | http://104.198.109.242/logs//PreCommit-HIVE-Build-15958/yetus/patch-asflicense-problems.txt
|
| modules | C: llap-server U: llap-server |
| Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-15958/yetus.txt |
| Powered by | Apache Yetus    http://yetus.apache.org |


This message was automatically generated.



> Make HS2 and LLAP consistent - Bring up LLAP WebUI in test mode if WebUI port is configured
> -------------------------------------------------------------------------------------------
>
>                 Key: HIVE-21221
>                 URL: https://issues.apache.org/jira/browse/HIVE-21221
>             Project: Hive
>          Issue Type: Improvement
>          Components: llap
>            Reporter: Oliver Draese
>            Assignee: Oliver Draese
>            Priority: Trivial
>              Labels: llap
>         Attachments: HIVE-21221.patch
>
>
> When HiveServer2 comes up, it skips the start of the WebUI if
> 1) hive.in.test is set to true
> AND
> 2) the WebUI port is not specified or default (hive.server2.webui.port)
>  
> Right now, on LLAP daemon start, it is only checked if hive is in test (condition 1)
above.
>  
> The LLAP Daemon start up code (to skip WebUI creation) should be consistent with HS2,
therefore if a port is specified (other than the default), the WebUI should also be started
in test mode.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message