hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-21228) Replace all occurences of new Integer with Integer.valueOf
Date Fri, 08 Feb 2019 14:13:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-21228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16763624#comment-16763624
] 

Hive QA commented on HIVE-21228:
--------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  0s{color} |
{color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  1m 43s{color} | {color:blue}
Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  7m 12s{color}
| {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  3m 28s{color} |
{color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  2m 17s{color}
| {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 40s{color} | {color:blue}
serde in master has 197 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  1m  8s{color} | {color:blue}
standalone-metastore/metastore-server in master has 183 extant Findbugs warnings. {color}
|
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  3m 55s{color} | {color:blue}
ql in master has 2298 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 40s{color} | {color:blue}
llap-server in master has 81 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 29s{color} | {color:blue}
beeline in master has 52 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 37s{color} | {color:blue}
hcatalog/core in master has 30 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 26s{color} | {color:blue}
hcatalog/hcatalog-pig-adapter in master has 2 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 41s{color} | {color:blue}
hplsql in master has 176 extant Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  2m 42s{color} |
{color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 27s{color} | {color:blue}
Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  3m 55s{color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  3m 31s{color} |
{color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  3m 31s{color} | {color:green}
the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 15s{color}
| {color:green} serde: The patch generated 0 new + 269 unchanged - 2 fixed = 269 total (was
271) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m  7s{color}
| {color:green} The patch metastore-server passed checkstyle {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 55s{color}
| {color:green} The patch ql passed checkstyle {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 12s{color}
| {color:green} The patch llap-server passed checkstyle {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 12s{color}
| {color:green} The patch beeline passed checkstyle {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 12s{color}
| {color:green} hcatalog/core: The patch generated 0 new + 15 unchanged - 4 fixed = 15 total
(was 19) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 11s{color}
| {color:green} The patch hcatalog-pig-adapter passed checkstyle {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 11s{color}
| {color:green} hplsql: The patch generated 0 new + 24 unchanged - 22 fixed = 24 total (was
46) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m  0s{color}
| {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 48s{color} |
{color:green} serde in the patch passed. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  1m 18s{color} |
{color:green} standalone-metastore/metastore-server generated 0 new + 181 unchanged - 2 fixed
= 181 total (was 183) {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  4m  7s{color} |
{color:green} ql generated 0 new + 2265 unchanged - 33 fixed = 2265 total (was 2298) {color}
|
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 49s{color} |
{color:green} llap-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 38s{color} |
{color:green} beeline generated 0 new + 45 unchanged - 7 fixed = 45 total (was 52) {color}
|
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 45s{color} |
{color:green} hcatalog/core generated 0 new + 29 unchanged - 1 fixed = 29 total (was 30) {color}
|
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 34s{color} |
{color:green} hcatalog-pig-adapter in the patch passed. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 50s{color} |
{color:green} hplsql generated 0 new + 174 unchanged - 2 fixed = 174 total (was 176) {color}
|
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  2m 45s{color} |
{color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red}  0m 14s{color} | {color:red}
The patch generated 1 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 50m 47s{color} | {color:black}
{color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03)
x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-15998/dev-support/hive-personality.sh
|
| git revision | master / 0223cbf |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| asflicense | http://104.198.109.242/logs//PreCommit-HIVE-Build-15998/yetus/patch-asflicense-problems.txt
|
| modules | C: serde standalone-metastore/metastore-server ql llap-server beeline hcatalog/core
hcatalog/hcatalog-pig-adapter hplsql U: . |
| Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-15998/yetus.txt |
| Powered by | Apache Yetus    http://yetus.apache.org |


This message was automatically generated.



> Replace all occurences of new Integer with Integer.valueOf
> ----------------------------------------------------------
>
>                 Key: HIVE-21228
>                 URL: https://issues.apache.org/jira/browse/HIVE-21228
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Ivan Suller
>            Assignee: Ivan Suller
>            Priority: Trivial
>         Attachments: HIVE-21228.01.patch, HIVE-21228.02.patch, HIVE-21228.03.patch
>
>
> Creating Integer objects with new Integer(...) creates a new object, while Integer.valueOf(...)
can be cached (and is actually cached in most if not all JVMs) thus reducing GC overhead.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message