hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (HIVE-13482) str_to_map function delimiters are regex
Date Sat, 02 Mar 2019 20:03:00 GMT

     [ https://issues.apache.org/jira/browse/HIVE-13482?focusedWorklogId=206781&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-206781
]

ASF GitHub Bot logged work on HIVE-13482:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 02/Mar/19 20:02
            Start Date: 02/Mar/19 20:02
    Worklog Time Spent: 10m 
      Work Description: MichaelChirico commented on issue #553: [HIVE-13482][UDF] Explicitly
define str_to_map args as regex
URL: https://github.com/apache/hive/pull/553#issuecomment-468955211
 
 
   @sankarh OK, done I think... though I update to master and now the diff on this PR looks
huge, the patch file is the much smaller diff from the first commit here.
   
   Please do advise if there's anything to fix
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 206781)
    Time Spent: 1h 20m  (was: 1h 10m)

> str_to_map function delimiters are regex
> ----------------------------------------
>
>                 Key: HIVE-13482
>                 URL: https://issues.apache.org/jira/browse/HIVE-13482
>             Project: Hive
>          Issue Type: Improvement
>          Components: UDF
>    Affects Versions: 1.0.0
>            Reporter: Janick Bernet
>            Assignee: Michael Chirico
>            Priority: Minor
>              Labels: pull-request-available
>         Attachments: HIVE-13482.patch, HIVE-13482.patch
>
>          Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> The two delimiters passed to the 'str_to_map' function are both interpreted as regular
expressions, which means that using the pipe ('|') as a delimiter will lead to very unexpected
results.
> This behaviour is the same for the closely related 'split' function, however that is
clearly documented in the function description (as per https://cwiki.apache.org/confluence/display/Hive/LanguageManual+UDF).

> Either the documentation for 'str_to_map' should be updated to reflect that the delimiters
are both regular expressions, too, or the implementation should be changed to not interpret
them as regexes.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message