hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-13482) str_to_map function delimiters are regex
Date Sat, 02 Mar 2019 20:25:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-13482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16782511#comment-16782511
] 

Hive QA commented on HIVE-13482:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12960894/HIVE-13482.patch

{color:red}ERROR:{color} -1 due to build exiting with an error

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/16318/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/16318/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-16318/

Messages:
{noformat}
**** This message was trimmed, see log for full details ****
Applied patch to 'ql/src/java/org/apache/hadoop/hive/ql/exec/spark/MapInput.java' cleanly.
error: patch failed: ql/src/java/org/apache/hadoop/hive/ql/exec/spark/ShuffleTran.java:71
Falling back to three-way merge...
Applied patch to 'ql/src/java/org/apache/hadoop/hive/ql/exec/spark/ShuffleTran.java' cleanly.
error: patch failed: ql/src/java/org/apache/hadoop/hive/ql/exec/tez/DagUtils.java:511
Falling back to three-way merge...
Applied patch to 'ql/src/java/org/apache/hadoop/hive/ql/exec/tez/DagUtils.java' cleanly.
error: patch failed: ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DbTxnManager.java:39
Falling back to three-way merge...
Applied patch to 'ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DbTxnManager.java' cleanly.
error: patch failed: ql/src/java/org/apache/hadoop/hive/ql/lockmgr/HiveTxnManager.java:19
Falling back to three-way merge...
Applied patch to 'ql/src/java/org/apache/hadoop/hive/ql/lockmgr/HiveTxnManager.java' cleanly.
error: patch failed: ql/src/java/org/apache/hadoop/hive/ql/lockmgr/HiveTxnManagerImpl.java:28
Falling back to three-way merge...
Applied patch to 'ql/src/java/org/apache/hadoop/hive/ql/lockmgr/HiveTxnManagerImpl.java' cleanly.
error: patch failed: ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/HiveRelMdRowCount.java:72
Falling back to three-way merge...
Applied patch to 'ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/HiveRelMdRowCount.java'
cleanly.
error: patch failed: ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/HiveRelMdSize.java:71
Falling back to three-way merge...
Applied patch to 'ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/HiveRelMdSize.java'
cleanly.
error: patch failed: ql/src/java/org/apache/hadoop/hive/ql/optimizer/correlation/CorrelationOptimizer.java:154
Falling back to three-way merge...
Applied patch to 'ql/src/java/org/apache/hadoop/hive/ql/optimizer/correlation/CorrelationOptimizer.java'
cleanly.
error: patch failed: ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/AbstractJoinTaskDispatcher.java:140
Falling back to three-way merge...
Applied patch to 'ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/AbstractJoinTaskDispatcher.java'
cleanly.
error: patch failed: ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/LlapDecider.java:382
Falling back to three-way merge...
Applied patch to 'ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/LlapDecider.java'
cleanly.
error: patch failed: ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/LlapPreVectorizationPass.java:101
Falling back to three-way merge...
Applied patch to 'ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/LlapPreVectorizationPass.java'
cleanly.
error: patch failed: ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java:70
Falling back to three-way merge...
Applied patch to 'ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java' cleanly.
error: patch failed: ql/src/java/org/apache/hadoop/hive/ql/parse/GenTezUtils.java:30
Falling back to three-way merge...
Applied patch to 'ql/src/java/org/apache/hadoop/hive/ql/parse/GenTezUtils.java' cleanly.
error: patch failed: ql/src/java/org/apache/hadoop/hive/ql/parse/repl/load/message/AlterDatabaseHandler.java:20
Falling back to three-way merge...
Applied patch to 'ql/src/java/org/apache/hadoop/hive/ql/parse/repl/load/message/AlterDatabaseHandler.java'
cleanly.
error: patch failed: ql/src/java/org/apache/hadoop/hive/ql/parse/repl/load/message/CreateDatabaseHandler.java:23
Falling back to three-way merge...
Applied patch to 'ql/src/java/org/apache/hadoop/hive/ql/parse/repl/load/message/CreateDatabaseHandler.java'
cleanly.
error: patch failed: ql/src/java/org/apache/hadoop/hive/ql/parse/repl/load/message/DropDatabaseHandler.java:18
Falling back to three-way merge...
Applied patch to 'ql/src/java/org/apache/hadoop/hive/ql/parse/repl/load/message/DropDatabaseHandler.java'
cleanly.
error: patch failed: ql/src/java/org/apache/hadoop/hive/ql/plan/DDLWork.java:37
Falling back to three-way merge...
Applied patch to 'ql/src/java/org/apache/hadoop/hive/ql/plan/DDLWork.java' cleanly.
error: patch failed: ql/src/java/org/apache/hadoop/hive/ql/plan/TezEdgeProperty.java:41
Falling back to three-way merge...
Applied patch to 'ql/src/java/org/apache/hadoop/hive/ql/plan/TezEdgeProperty.java' cleanly.
error: patch failed: ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFAverage.java:130
Falling back to three-way merge...
Applied patch to 'ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFAverage.java'
cleanly.
error: patch failed: ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFSum.java:492
Falling back to three-way merge...
Applied patch to 'ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFSum.java' cleanly.
Falling back to three-way merge...
Applied patch to 'ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDTFGetSQLSchema.java'
cleanly.
error: patch failed: ql/src/java/org/apache/hadoop/hive/ql/udf/generic/NGramEstimator.java:102
Falling back to three-way merge...
Applied patch to 'ql/src/java/org/apache/hadoop/hive/ql/udf/generic/NGramEstimator.java' cleanly.
error: patch failed: ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorizationContext.java:474
Falling back to three-way merge...
Applied patch to 'ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorizationContext.java'
cleanly.
error: patch failed: ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorBetweenIn.java:464
Falling back to three-way merge...
Applied patch to 'ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorBetweenIn.java'
cleanly.
error: patch failed: ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestInputOutputFormat.java:2655
Falling back to three-way merge...
Applied patch to 'ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestInputOutputFormat.java'
cleanly.
error: patch failed: ql/src/test/org/apache/hadoop/hive/ql/io/parquet/TestParquetRecordReaderWrapper.java:153
Falling back to three-way merge...
Applied patch to 'ql/src/test/org/apache/hadoop/hive/ql/io/parquet/TestParquetRecordReaderWrapper.java'
cleanly.
error: patch failed: ql/src/test/org/apache/hadoop/hive/ql/io/sarg/TestSearchArgumentImpl.java:412
Falling back to three-way merge...
Applied patch to 'ql/src/test/org/apache/hadoop/hive/ql/io/sarg/TestSearchArgumentImpl.java'
cleanly.
error: patch failed: ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPDivide.java:32
Falling back to three-way merge...
Applied patch to 'ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPDivide.java'
cleanly.
error: patch failed: ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPMinus.java:49
Falling back to three-way merge...
Applied patch to 'ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPMinus.java'
cleanly.
error: patch failed: ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPMultiply.java:41
Falling back to three-way merge...
Applied patch to 'ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPMultiply.java'
cleanly.
error: patch failed: ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPNegative.java:46
Falling back to three-way merge...
Applied patch to 'ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPNegative.java'
cleanly.
error: patch failed: ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPPlus.java:49
Falling back to three-way merge...
Applied patch to 'ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPPlus.java'
cleanly.
error: patch failed: ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPPositive.java:46
Falling back to three-way merge...
Applied patch to 'ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPPositive.java'
cleanly.
error: patch failed: ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFPower.java:39
Falling back to three-way merge...
Applied patch to 'ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFPower.java'
cleanly.
Falling back to three-way merge...
Applied patch to 'ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDTFGetSQLSchema.java'
cleanly.
Falling back to three-way merge...
Applied patch to 'ql/src/test/queries/clientpositive/udtf_get_sql_schema.q' cleanly.
error: patch failed: ql/src/test/results/clientnegative/database_create_already_exists.q.out:12
Falling back to three-way merge...
Applied patch to 'ql/src/test/results/clientnegative/database_create_already_exists.q.out'
cleanly.
error: patch failed: ql/src/test/results/clientnegative/database_create_invalid_name.q.out:6
Falling back to three-way merge...
Applied patch to 'ql/src/test/results/clientnegative/database_create_invalid_name.q.out' cleanly.
error: patch failed: ql/src/test/results/clientnegative/database_drop_not_empty.q.out:33
Falling back to three-way merge...
Applied patch to 'ql/src/test/results/clientnegative/database_drop_not_empty.q.out' cleanly.
error: patch failed: ql/src/test/results/clientnegative/database_drop_not_empty_restrict.q.out:33
Falling back to three-way merge...
Applied patch to 'ql/src/test/results/clientnegative/database_drop_not_empty_restrict.q.out'
cleanly.
error: patch failed: ql/src/test/results/clientnegative/dbtxnmgr_nodblock.q.out:12
Falling back to three-way merge...
Applied patch to 'ql/src/test/results/clientnegative/dbtxnmgr_nodblock.q.out' cleanly.
error: patch failed: ql/src/test/results/clientnegative/dbtxnmgr_nodbunlock.q.out:12
Falling back to three-way merge...
Applied patch to 'ql/src/test/results/clientnegative/dbtxnmgr_nodbunlock.q.out' cleanly.
error: patch failed: ql/src/test/results/clientnegative/lockneg_query_tbl_in_locked_db.q.out:59
Falling back to three-way merge...
Applied patch to 'ql/src/test/results/clientnegative/lockneg_query_tbl_in_locked_db.q.out'
cleanly.
error: patch failed: ql/src/test/results/clientnegative/lockneg_try_db_lock_conflict.q.out:17
Falling back to three-way merge...
Applied patch to 'ql/src/test/results/clientnegative/lockneg_try_db_lock_conflict.q.out' cleanly.
error: patch failed: ql/src/test/results/clientnegative/lockneg_try_lock_db_in_use.q.out:49
Falling back to three-way merge...
Applied patch to 'ql/src/test/results/clientnegative/lockneg_try_lock_db_in_use.q.out' cleanly.
error: patch failed: ql/src/test/results/clientpositive/encrypted/encryption_move_tbl.q.out:230
Falling back to three-way merge...
Applied patch to 'ql/src/test/results/clientpositive/encrypted/encryption_move_tbl.q.out'
cleanly.
error: patch failed: ql/src/test/results/clientpositive/show_functions.q.out:111
Falling back to three-way merge...
Applied patch to 'ql/src/test/results/clientpositive/show_functions.q.out' cleanly.
Falling back to three-way merge...
Applied patch to 'ql/src/test/results/clientpositive/udtf_get_sql_schema.q.out' cleanly.
error: patch failed: serde/src/java/org/apache/hadoop/hive/serde2/thrift/ColumnBuffer.java:381
Falling back to three-way merge...
Applied patch to 'serde/src/java/org/apache/hadoop/hive/serde2/thrift/ColumnBuffer.java' cleanly.
error: patch failed: serde/src/test/org/apache/hadoop/hive/serde2/objectinspector/TestUnionStructObjectInspector.java:100
Falling back to three-way merge...
Applied patch to 'serde/src/test/org/apache/hadoop/hive/serde2/objectinspector/TestUnionStructObjectInspector.java'
cleanly.
error: patch failed: service/src/java/org/apache/hive/service/auth/ldap/GroupFilterFactory.java:86
Falling back to three-way merge...
Applied patch to 'service/src/java/org/apache/hive/service/auth/ldap/GroupFilterFactory.java'
cleanly.
error: patch failed: service/src/test/org/apache/hive/service/auth/ldap/TestGroupFilter.java:105
Falling back to three-way merge...
Applied patch to 'service/src/test/org/apache/hive/service/auth/ldap/TestGroupFilter.java'
cleanly.
error: patch failed: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/common/ndv/fm/FMSketch.java:118
Falling back to three-way merge...
Applied patch to 'standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/common/ndv/fm/FMSketch.java'
cleanly.
error: patch failed: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java:1597
Falling back to three-way merge...
Applied patch to 'standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java'
cleanly.
error: patch failed: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/IMetaStoreSchemaInfo.java:22
Falling back to three-way merge...
Applied patch to 'standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/IMetaStoreSchemaInfo.java'
cleanly.
error: patch failed: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreSchemaInfo.java:30
Falling back to three-way merge...
Applied patch to 'standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreSchemaInfo.java'
cleanly.
error: patch failed: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/metrics/PerfLogger.java:73
Falling back to three-way merge...
Applied patch to 'standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/metrics/PerfLogger.java'
cleanly.
error: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/tools/HiveSchemaHelper.java:
does not exist in index
error: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/tools/MetastoreSchemaTool.java:
does not exist in index
error: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/tools/SchemaToolCommandLine.java:
does not exist in index
error: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/tools/SchemaToolTask.java:
does not exist in index
error: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/tools/SchemaToolTaskAlterCatalog.java:
does not exist in index
error: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/tools/SchemaToolTaskCreateCatalog.java:
does not exist in index
error: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/tools/SchemaToolTaskCreateUser.java:
does not exist in index
error: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/tools/SchemaToolTaskInfo.java:
does not exist in index
error: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/tools/SchemaToolTaskInit.java:
does not exist in index
error: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/tools/SchemaToolTaskInitOrUpgrade.java:
does not exist in index
error: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/tools/SchemaToolTaskMoveDatabase.java:
does not exist in index
error: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/tools/SchemaToolTaskMoveTable.java:
does not exist in index
error: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/tools/SchemaToolTaskUpgrade.java:
does not exist in index
error: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/tools/SchemaToolTaskValidate.java:
does not exist in index
error: patch failed: standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestFilterHooks.java:356
Falling back to three-way merge...
Applied patch to 'standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestFilterHooks.java'
cleanly.
Falling back to three-way merge...
Applied patch to 'standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestHmsServerAuthorization.java'
cleanly.
error: patch failed: standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/dbinstall/DbInstallBase.java:19
Falling back to three-way merge...
Applied patch to 'standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/dbinstall/DbInstallBase.java'
cleanly.
error: standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/tools/TestMetastoreSchemaTool.java:
does not exist in index
error: standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/tools/TestSchemaToolForMetastore.java:
does not exist in index
fatal: git apply: bad git-diff - inconsistent old filename on line 943
fatal: git apply: bad git-diff - inconsistent old filename on line 943
The patch does not appear to apply with p0, p1, or p2
+ result=1
+ '[' 1 -ne 0 ']'
+ rm -rf yetus_PreCommit-HIVE-Build-16318
+ exit 1
'
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12960894 - PreCommit-HIVE-Build

> str_to_map function delimiters are regex
> ----------------------------------------
>
>                 Key: HIVE-13482
>                 URL: https://issues.apache.org/jira/browse/HIVE-13482
>             Project: Hive
>          Issue Type: Improvement
>          Components: UDF
>    Affects Versions: 1.0.0
>            Reporter: Janick Bernet
>            Assignee: Michael Chirico
>            Priority: Minor
>              Labels: pull-request-available
>         Attachments: HIVE-13482.patch, HIVE-13482.patch
>
>          Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> The two delimiters passed to the 'str_to_map' function are both interpreted as regular
expressions, which means that using the pipe ('|') as a delimiter will lead to very unexpected
results.
> This behaviour is the same for the closely related 'split' function, however that is
clearly documented in the function description (as per https://cwiki.apache.org/confluence/display/Hive/LanguageManual+UDF).

> Either the documentation for 'str_to_map' should be updated to reflect that the delimiters
are both regular expressions, too, or the implementation should be changed to not interpret
them as regexes.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message