hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Laszlo Bodor (JIRA)" <>
Subject [jira] [Commented] (HIVE-15406) Consider vectorizing the new 'trunc' function
Date Thu, 21 Mar 2019 11:06:00 GMT


Laszlo Bodor commented on HIVE-15406:

thanks for the review [~kgyrtkirk]
1. the zeros are the same as in nonvectorized execution, and it's because trunc function doesn't
respect the input scale when it produces output, see:
HiveDecimal has also a constructor with scale parameter, but it's not used

2. attached the same queries in nonvectorized mode

i agree that it could be annoying to see leading zeros when the input is casted to (10,5),
but for now, it could remain as a sign that it should be reviewed later (in both vec and nonvec

> Consider vectorizing the new 'trunc' function
> ---------------------------------------------
>                 Key: HIVE-15406
>                 URL:
>             Project: Hive
>          Issue Type: Bug
>          Components: Vectorization
>    Affects Versions: 4.0.0
>            Reporter: Matt McCline
>            Assignee: Laszlo Bodor
>            Priority: Critical
>         Attachments: HIVE-15406.01.patch, HIVE-15406.02.patch, HIVE-15406.03.patch, HIVE-15406.04.patch,
HIVE-15406.05.patch, HIVE-15406.06.patch
> Rounding function 'trunc' added by HIVE-14582.

This message was sent by Atlassian JIRA

View raw message