hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Peter Vary (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-20580) OrcInputFormat.isOriginal() should not rely on hive.acid.key.index
Date Tue, 19 Mar 2019 10:15:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-20580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16795934#comment-16795934
] 

Peter Vary commented on HIVE-20580:
-----------------------------------

[~ekoifman]: The {{isOriginal(Footer footer)}} is called from {{org.apache.hadoop.hive.llap.io.metadata.OrcFileMetadata}}
constructor, and the value set by the constructor is only used to implement the {{org.apache.orc.FileMetadata.isOriginalFormat()}}
interface method which in turn is not called anywhere in the Hive code base.
 Since this is an external interface I rather not leave the method unimplemented, even if
it is not called anywhere at the moment. On the other hand you confirmed that I correctly
understood the meaning of the isOriginal, so I think it is ok to fix the output of the other
method to match the same as well.

Thanks for the help [~ekoifman]!!!
 Really appreciate it!

Peter

> OrcInputFormat.isOriginal() should not rely on hive.acid.key.index
> ------------------------------------------------------------------
>
>                 Key: HIVE-20580
>                 URL: https://issues.apache.org/jira/browse/HIVE-20580
>             Project: Hive
>          Issue Type: Improvement
>          Components: Transactions
>    Affects Versions: 3.1.0
>            Reporter: Eugene Koifman
>            Assignee: Peter Vary
>            Priority: Major
>         Attachments: HIVE-20580.2.patch, HIVE-20580.3.patch, HIVE-20580.4.patch, HIVE-20580.5.patch,
HIVE-20580.6.patch, HIVE-20580.patch
>
>
> {{org.apache.hadoop.hive.ql.io.orc.OrcInputFormat.isOriginal()}} is checking for presence
of {{hive.acid.key.index}} in the footer.  This is only created when the file is written by
{{OrcRecordUpdater}}.  It should instead check for presence of Acid metadata columns so that
a file can be produced by something other than {{OrcRecordUpater}}.
> Also, {{hive.acid.key.index}} counts number of different type of events which is not
really useful for Acid V2 (as of Hive 3) since each file only has 1 type of event.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message