hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (HIVE-21109) Stats replication for ACID tables.
Date Wed, 27 Mar 2019 09:25:00 GMT

     [ https://issues.apache.org/jira/browse/HIVE-21109?focusedWorklogId=219217&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-219217
]

ASF GitHub Bot logged work on HIVE-21109:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 27/Mar/19 09:24
            Start Date: 27/Mar/19 09:24
    Worklog Time Spent: 10m 
      Work Description: ashutosh-bapat commented on pull request #579: HIVE-21109 : Support
stats replication for ACID tables.
URL: https://github.com/apache/hive/pull/579#discussion_r269467699
 
 

 ##########
 File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
 ##########
 @@ -2130,11 +2144,18 @@ private void create_table_core(final RawStore ms, final Table tbl,
 
       // If the table has column statistics, update it into the metastore. This feature is
used
       // by replication to replicate table level statistics.
-      if (tbl.isSetColStats()) {
-        // We do not replicate statistics for a transactional table right now and hence we
do not
-        // expect a transactional table to have column statistics here. So passing null
-        // validWriteIds is fine for now.
-        updateTableColumnStatsInternal(tbl.getColStats(), null, tbl.getWriteId());
+      if (colStats != null) {
+        // On replica craft a valid snapshot out of the writeId in the table.
+        long writeId = tbl.getWriteId();
+        String validWriteIds = null;
+        if (writeId > 0) {
+          ValidWriteIdList vwil =
+                  new ValidReaderWriteIdList(TableName.getDbTable(tbl.getDbName(),
 
 Review comment:
   Done. Please check.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 219217)
    Time Spent: 3h 40m  (was: 3.5h)

> Stats replication for ACID tables.
> ----------------------------------
>
>                 Key: HIVE-21109
>                 URL: https://issues.apache.org/jira/browse/HIVE-21109
>             Project: Hive
>          Issue Type: Sub-task
>            Reporter: Ashutosh Bapat
>            Assignee: Ashutosh Bapat
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: HIVE-21109.01.patch, HIVE-21109.02.patch, HIVE-21109.03.patch, HIVE-21109.04.patch,
HIVE-21109.05.patch, HIVE-21109.06.patch
>
>          Time Spent: 3h 40m
>  Remaining Estimate: 0h
>
> Transactional tables require a writeID associated with the stats update. This writeId
needs to be in sync with the writeId on the source and hence needs to be replicated from
the source.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message