hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (HIVE-21109) Stats replication for ACID tables.
Date Wed, 27 Mar 2019 12:04:00 GMT

     [ https://issues.apache.org/jira/browse/HIVE-21109?focusedWorklogId=219266&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-219266
]

ASF GitHub Bot logged work on HIVE-21109:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 27/Mar/19 12:03
            Start Date: 27/Mar/19 12:03
    Worklog Time Spent: 10m 
      Work Description: ashutosh-bapat commented on pull request #579: HIVE-21109 : Support
stats replication for ACID tables.
URL: https://github.com/apache/hive/pull/579#discussion_r269523732
 
 

 ##########
 File path: ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java
 ##########
 @@ -2689,7 +2689,19 @@ private int alterTable(Hive db, AlterTableDesc alterTbl) throws HiveException
{
       } else {
         // Note: this is necessary for UPDATE_STATISTICS command, that operates via ADDPROPS
(why?).
         //       For any other updates, we don't want to do txn check on partitions when
altering table.
-        boolean isTxn = alterTbl.getPartSpec() != null && alterTbl.getOp() == AlterTableTypes.ADDPROPS;
+        boolean isTxn = false;
+        if (alterTbl.getPartSpec() != null && alterTbl.getOp() == AlterTableTypes.ADDPROPS)
{
+          // ADDPROPS is used to add repl.last.id during replication. That's not a transactional
+          // change.
+          Map<String, String> props = alterTbl.getProps();
+          if (props.size() <= 1 && props.get(ReplicationSpec.KEY.CURR_STATE_ID.toString())
!= null) {
 
 Review comment:
   The comment 
   
           // Note: this is necessary for UPDATE_STATISTICS command, that operates via ADDPROPS
(why?).
           //       For any other updates, we don't want to do txn check on partitions when
altering table.
   
   itself looks wrong. I do not see any ADDPROPS usage which is updating statistics properties.
All those seem to come through AddPartition and not alterTable for partitioned table. So,
may be we can safely mark this as non-transactional always. Does that look right?
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 219266)
    Time Spent: 4h 40m  (was: 4.5h)

> Stats replication for ACID tables.
> ----------------------------------
>
>                 Key: HIVE-21109
>                 URL: https://issues.apache.org/jira/browse/HIVE-21109
>             Project: Hive
>          Issue Type: Sub-task
>            Reporter: Ashutosh Bapat
>            Assignee: Ashutosh Bapat
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: HIVE-21109.01.patch, HIVE-21109.02.patch, HIVE-21109.03.patch, HIVE-21109.04.patch,
HIVE-21109.05.patch, HIVE-21109.06.patch
>
>          Time Spent: 4h 40m
>  Remaining Estimate: 0h
>
> Transactional tables require a writeID associated with the stats update. This writeId
needs to be in sync with the writeId on the source and hence needs to be replicated from
the source.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message