hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (HIVE-21286) Hive should support clean-up of previously bootstrapped tables when retry from different dump.
Date Mon, 04 Mar 2019 16:53:00 GMT

     [ https://issues.apache.org/jira/browse/HIVE-21286?focusedWorklogId=207281&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-207281
]

ASF GitHub Bot logged work on HIVE-21286:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 04/Mar/19 16:52
            Start Date: 04/Mar/19 16:52
    Worklog Time Spent: 10m 
      Work Description: ashutosh-bapat commented on pull request #551: HIVE-21286: Hive should
support clean-up of previously bootstrapped tables when retry from different dump.
URL: https://github.com/apache/hive/pull/551#discussion_r262125175
 
 

 ##########
 File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplLoadTask.java
 ##########
 @@ -279,6 +292,72 @@ a database ( directory )
     return 0;
   }
 
+  /**
+   * Cleanup/drop tables from the given database which are bootstrapped by input dump dir.
+   * @throws HiveException Failed to drop the tables.
+   * @throws IOException File operations failure.
+   * @throws InvalidInputException Invalid input dump directory.
+   */
+  private void bootstrapRollbackTask() throws HiveException, IOException, InvalidInputException
{
+    Path bootstrapDirectory = new PathBuilder(work.bootstrapDumpToRollback)
+            .addDescendant(ReplUtils.INC_BOOTSTRAP_ROOT_DIR_NAME).build();
+    FileSystem fs = bootstrapDirectory.getFileSystem(conf);
+
+    if (!fs.exists(bootstrapDirectory)) {
+      throw new InvalidInputException("Input bootstrap dump directory to rollback doesn't
exist: "
+              + bootstrapDirectory);
 
 Review comment:
   Please add a test case covering this error i.e. when an invalid bootstrap dump location
is specified. If the specified bootstrap dump (to rollback) location exists, how do we know
that it is indeed the bootstrap dump location for external tables and not some other dump
location like a genuine incremental dump or a genuine bootstrap dump? We should add testcases
for the same as well.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 207281)
    Time Spent: 20m  (was: 10m)

> Hive should support clean-up of previously bootstrapped tables when retry from different
dump.
> ----------------------------------------------------------------------------------------------
>
>                 Key: HIVE-21286
>                 URL: https://issues.apache.org/jira/browse/HIVE-21286
>             Project: Hive
>          Issue Type: Bug
>          Components: repl
>    Affects Versions: 4.0.0
>            Reporter: Sankar Hariappan
>            Assignee: Sankar Hariappan
>            Priority: Major
>              Labels: DR, Replication, pull-request-available
>         Attachments: HIVE-21286.01.patch
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> If external tables are enabled for replication on an existing repl policy, then bootstrapping
of external tables are combined with incremental dump.
> If incremental bootstrap load fails with non-retryable error for which user will have
to manually drop all the external tables before trying with another bootstrap dump. For full
bootstrap, to retry with different dump, we suggested user to drop the DB but in this case
they need to manually drop all the external tables which is not so user friendly. So, need
to handle it in Hive side as follows.
> REPL LOAD takes additional config (passed by user in WITH clause) that says, drop all
the tables which are bootstrapped from previous dump. 
> hive.repl.rollback.bootstrap.load=<previous_bootstrap_dump_dir>
> Hive will use this config only if the current dump is bootstrap dump or combined bootstrap
in incremental dump.
> Caution to be taken by user that this config should not be passed if previous REPL LOAD
(with bootstrap) was successful or any successful incremental dump+load happened after "previous_bootstrap_dump_dir".



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message