hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-21371) Make NonSyncByteArrayOutputStream Overflow Conscious
Date Tue, 05 Mar 2019 20:56:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-21371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16784897#comment-16784897
] 

Hive QA commented on HIVE-21371:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12961165/HIVE-21371.2.patch

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:green}SUCCESS:{color} +1 due to 15817 tests passed

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/16348/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/16348/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-16348/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12961165 - PreCommit-HIVE-Build

> Make NonSyncByteArrayOutputStream Overflow Conscious 
> -----------------------------------------------------
>
>                 Key: HIVE-21371
>                 URL: https://issues.apache.org/jira/browse/HIVE-21371
>             Project: Hive
>          Issue Type: Improvement
>    Affects Versions: 4.0.0, 3.2.0
>            Reporter: David Mollitor
>            Assignee: David Mollitor
>            Priority: Minor
>         Attachments: HIVE-21371.1.patch, HIVE-21371.2.patch, HIVE-21371.2.patch, HIVE-21371.2.patch
>
>
> {code:java|title=NonSyncByteArrayOutputStream}
>   private int enLargeBuffer(int increment) {
>     int temp = count + increment;
>     int newLen = temp;
>     if (temp > buf.length) {
>       if ((buf.length << 1) > temp) {
>         newLen = buf.length << 1;
>       }
>       byte newbuf[] = new byte[newLen];
>       System.arraycopy(buf, 0, newbuf, 0, count);
>       buf = newbuf;
>     }
>     return newLen;
>   }
> {code}
> This will fail if the array is 2GB or larger because it will double the size every time
without consideration for the 4GB limit on arrays.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message