hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Peter Vary (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-21377) Using Oracle as HMS DB with DirectSQL
Date Wed, 06 Mar 2019 08:20:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-21377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16785402#comment-16785402
] 

Peter Vary commented on HIVE-21377:
-----------------------------------

[~hibosoon]: Could we add unit tests so we will not have such problems later?

> Using Oracle as HMS DB with DirectSQL
> -------------------------------------
>
>                 Key: HIVE-21377
>                 URL: https://issues.apache.org/jira/browse/HIVE-21377
>             Project: Hive
>          Issue Type: Improvement
>          Components: Metastore
>    Affects Versions: 3.0.0, 3.1.0
>            Reporter: Bo 
>            Assignee: Rajkumar Singh
>            Priority: Major
>         Attachments: HIVE-21377.patch
>
>
> When we use the Oracle as HMS DB, we saw this kind of contents in the HMS log accordingly:
> {code:java}
> 2019-02-02 T08:23:57,102 WARN [Thread-12]: metastore.ObjectStore (ObjectStore.java:handleDirectSqlError(3741))
- Falling back to ORM path due to direct SQL failure (this is not an error): Cannot extract
boolean from column value 0 at org.apache.hadoop.hive.metastore.MetaStoreDirectSql.extractSqlBoolean(MetaStoreDirectSql.java:1031)
at org.apache.hadoop.hive.metastore.MetaStoreDirectSql.getPartitionsFromPartitionIds(MetaStoreDirectSql.java:728)
at org.apache.hadoop.hive.metastore.MetaStoreDirectSql.access$300(MetaStoreDirectSql.java:109)
at org.apache.hadoop.hive.metastore.MetaStoreDirectSql$1.run(MetaStoreDirectSql.java:471)
at org.apache.hadoop.hive.metastore.Batchable.runBatched(Batchable.java:73) at org.apache.hadoop.hive.metastore.MetaStoreDirectSql.getPartitionsViaSqlFilter(MetaStoreDirectSql.java:462)
at org.apache.hadoop.hive.metastore.ObjectStore$8.getSqlResult(ObjectStore.java:3392)
> {code}
> In Hive, we handle the Postgres, MySQL and Derby for the extractSqlBoolean.
> But Oracle return the 0 or 1 for Boolean. So we need to modify the MetastoreDirectSqlUtils.java
- [1]
> So, could add this snip in this code?
> {code:java}
>   static Boolean extractSqlBoolean(Object value) throws MetaException {
>     if (value == null) {
>       return null;
>     }
>     if (value instanceof Boolean) {
>       return (Boolean)value;
>     }
>     if (value instanceof Number) { // add
>       try {
>         return BooleanUtils.toBooleanObject((BigDecimal) value, 1, 0, null);
>       } catch(IllegalArugmentExeception iae){
>       // NOOP
>       }
>     if (value instanceof String) {
>       try {
>         return BooleanUtils.toBooleanObject((String) value, "Y", "N", null);
>       } catch (IllegalArgumentException iae) {
>         // NOOP
>       }
>     }
>     throw new MetaException("Cannot extract boolean from column value " + value);
>   }
> {code}
>  [1] -
> https://github.com/apache/hive/blob/f51f108b761f0c88647f48f30447dae12b308f31/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetastoreDirectSqlUtils.java#L501-L527
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message