hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-21465) Introduce a base abstract VectorExpression to eliminate further code duplications
Date Thu, 21 Mar 2019 23:46:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-21465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16798552#comment-16798552
] 

Hive QA commented on HIVE-21465:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12963272/HIVE-21465.02.patch

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:green}SUCCESS:{color} +1 due to 15833 tests passed

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/16618/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/16618/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-16618/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12963272 - PreCommit-HIVE-Build

> Introduce a base abstract VectorExpression to eliminate further code duplications
> ---------------------------------------------------------------------------------
>
>                 Key: HIVE-21465
>                 URL: https://issues.apache.org/jira/browse/HIVE-21465
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Laszlo Bodor
>            Assignee: Laszlo Bodor
>            Priority: Major
>         Attachments: HIVE-21465.01.patch, HIVE-21465.02.patch
>
>
> In vectorized expressions, from time to time, I see a similar/same logic to be repeated,
which always consists of some stuff like:
> 1. some inner loops (even the comments are the same)
> {code}
> grep -iRH "Set isNull before call in case it changes it mind" | grep "ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/"
> {code}
> 2. call to an actual "business logic" function ==> 1 line which could be abstracted...
and it has been abstracted in hive codebase in n different cases.
> However, an abstract BaseVectorExpression would not force anybody to extend it instead
of VectorExpression and not copy the code again, but it could be a good start and an example.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message