hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-21480) Fix test TestHiveMetaStore.testJDOPersistanceManagerCleanup
Date Thu, 21 Mar 2019 14:33:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-21480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16798139#comment-16798139
] 

Hive QA commented on HIVE-21480:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12963214/HIVE-21480.1.patch

{color:red}ERROR:{color} -1 due to build exiting with an error

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/16611/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/16611/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-16611/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Tests exited with: Exception: Patch URL https://issues.apache.org/jira/secure/attachment/12963214/HIVE-21480.1.patch
was found in seen patch url's cache and a test was probably run already on it. Aborting...
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12963214 - PreCommit-HIVE-Build

> Fix test TestHiveMetaStore.testJDOPersistanceManagerCleanup
> -----------------------------------------------------------
>
>                 Key: HIVE-21480
>                 URL: https://issues.apache.org/jira/browse/HIVE-21480
>             Project: Hive
>          Issue Type: Improvement
>          Components: Standalone Metastore
>    Affects Versions: 4.0.0
>            Reporter: Morio Ramdenbourg
>            Assignee: Morio Ramdenbourg
>            Priority: Major
>         Attachments: HIVE-21480.1.patch, HIVE-21480.patch
>
>
> [TestHiveMetaStore#testJDOPersistanceManagerCleanup|https://github.com/apache/hive/blob/master/standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java#L3140-L3162]
tests whether the JDO persistence manager cache cleanup was performed correctly when a HiveMetaStoreClient
executes an API call, and closes. It does this by ensuring that the cache object count before
the API call, and after closing, are the same. However, there are some assumptions that are
not always correct, and can cause flakiness.
> For example, lingering resources could be present from previous tests or from setup depending
on how PTest runs it, and can cause the object count to sometimes be incorrect. We should
rewrite this test to account for this flakiness that can occur.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message