hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (HIVE-21109) Stats replication for ACID tables.
Date Mon, 01 Apr 2019 10:00:18 GMT

     [ https://issues.apache.org/jira/browse/HIVE-21109?focusedWorklogId=221206&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-221206
]

ASF GitHub Bot logged work on HIVE-21109:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 01/Apr/19 10:00
            Start Date: 01/Apr/19 10:00
    Worklog Time Spent: 10m 
      Work Description: ashutosh-bapat commented on pull request #579: HIVE-21109 : Support
stats replication for ACID tables.
URL: https://github.com/apache/hive/pull/579#discussion_r270795354
 
 

 ##########
 File path: itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/parse/TestStatsReplicationScenarios.java
 ##########
 @@ -301,12 +338,106 @@ private String dumpLoadVerify(List<String> tableNames, String
lastReplicationId,
     return dumpTuple.lastReplicationId;
   }
 
+  /**
+   * Run a bootstrap that will fail.
+   * @param tuple the location of bootstrap dump
+   */
+  private void failBootstrapLoad(WarehouseInstance.Tuple tuple, int failAfterNumTables) throws
Throwable {
+    // fail setting ckpt directory property for the second table so that we test the case
when
+    // bootstrap load fails after some but not all tables are loaded.
+    BehaviourInjection<CallerArguments, Boolean> callerVerifier
+            = new BehaviourInjection<CallerArguments, Boolean>() {
+      int cntTables = 0;
+      @Nullable
+      @Override
+      public Boolean apply(@Nullable CallerArguments args) {
+        cntTables++;
+        if (args.dbName.equalsIgnoreCase(replicatedDbName) && cntTables > failAfterNumTables)
{
+          injectionPathCalled = true;
+          LOG.warn("Verifier - DB : " + args.dbName + " TABLE : " + args.tblName);
+          return false;
+        }
+        return true;
+      }
+    };
+
+    InjectableBehaviourObjectStore.setAlterTableModifier(callerVerifier);
+    try {
+      replica.loadFailure(replicatedDbName, tuple.dumpLocation);
+      callerVerifier.assertInjectionsPerformed(true, false);
+    } finally {
+      InjectableBehaviourObjectStore.resetAlterTableModifier();
+    }
+  }
+
+  private void failIncrementalLoad(WarehouseInstance.Tuple dumpTuple, int failAfterNumEvents)
throws Throwable {
+    // fail add notification when updating table stats after given number of such events.
Thus we
+    // test successful application as well as failed application of this event.
+    BehaviourInjection<NotificationEvent, Boolean> callerVerifier
+            = new BehaviourInjection<NotificationEvent, Boolean>() {
+      int cntEvents = 0;
+      @Override
+      public Boolean apply(NotificationEvent entry) {
+        cntEvents++;
 
 Review comment:
   This code has changed while working on another related comment. Again we don't need to
count exact number of events. We need at least one successful event and other one unsuccessful
event.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 221206)
    Time Spent: 10h 10m  (was: 10h)

> Stats replication for ACID tables.
> ----------------------------------
>
>                 Key: HIVE-21109
>                 URL: https://issues.apache.org/jira/browse/HIVE-21109
>             Project: Hive
>          Issue Type: Sub-task
>            Reporter: Ashutosh Bapat
>            Assignee: Ashutosh Bapat
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: HIVE-21109.01.patch, HIVE-21109.02.patch, HIVE-21109.03.patch, HIVE-21109.04.patch,
HIVE-21109.05.patch, HIVE-21109.06.patch, HIVE-21109.07.patch, HIVE-21109.08.patch
>
>          Time Spent: 10h 10m
>  Remaining Estimate: 0h
>
> Transactional tables require a writeID associated with the stats update. This writeId
needs to be in sync with the writeId on the source and hence needs to be replicated from
the source.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message