hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (HIVE-21529) Hive support bootstrap of ACID/MM tables on an existing policy.
Date Mon, 01 Apr 2019 15:34:00 GMT

     [ https://issues.apache.org/jira/browse/HIVE-21529?focusedWorklogId=221332&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-221332
]

ASF GitHub Bot logged work on HIVE-21529:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 01/Apr/19 15:33
            Start Date: 01/Apr/19 15:33
    Worklog Time Spent: 10m 
      Work Description: sankarh commented on pull request #581: HIVE-21529 : Bootstrap ACID
tables as part of incremental dump.
URL: https://github.com/apache/hive/pull/581#discussion_r270898935
 
 

 ##########
 File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplDumpTask.java
 ##########
 @@ -193,27 +226,39 @@ private Long incrementalDump(Path dumpRoot, DumpMetaData dmd, Path
cmRoot, Hive
     dmd.setDump(DumpType.INCREMENTAL, work.eventFrom, lastReplId, cmRoot);
     dmd.write();
 
-    // If external tables are enabled for replication and
-    // - If bootstrap is enabled, then need to combine bootstrap dump of external tables.
-    // - If metadata-only dump is enabled, then shall skip dumping external tables data locations
to
-    //   _external_tables_info file. If not metadata-only, then dump the data locations.
-    if (conf.getBoolVar(HiveConf.ConfVars.REPL_INCLUDE_EXTERNAL_TABLES)
-        && (!conf.getBoolVar(HiveConf.ConfVars.REPL_DUMP_METADATA_ONLY)
-        || conf.getBoolVar(HiveConf.ConfVars.REPL_BOOTSTRAP_EXTERNAL_TABLES))) {
+    // Examine all the tables if required.
+    if (shouldExamineTablesToDump()) {
       Path dbRoot = getBootstrapDbRoot(dumpRoot, dbName, true);
+
+      // If we are bootstrapping ACID tables, stop all the concurrent transactions and take
a
+      // snapshot to dump those tables. Record the last event id in case we are performing
+      // bootstrap of ACID tables.
+      String validTxnList = null;
+      long bootstrapLastReplId = 0;
+      if (conf.getBoolVar(HiveConf.ConfVars.REPL_BOOTSTRAP_ACID_TABLES)) {
+        validTxnList = getValidTxnListForReplDump(hiveDb);
+        bootstrapLastReplId = hiveDb.getMSC().getCurrentNotificationEventId().getEventId();
+      }
+
       try (Writer writer = new Writer(dumpRoot, conf)) {
 
 Review comment:
   Shall we create the _external_info file only if shouldDumpExternalTableLocation?
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 221332)
    Time Spent: 0.5h  (was: 20m)

> Hive support bootstrap of ACID/MM tables on an existing policy.
> ---------------------------------------------------------------
>
>                 Key: HIVE-21529
>                 URL: https://issues.apache.org/jira/browse/HIVE-21529
>             Project: Hive
>          Issue Type: Sub-task
>          Components: repl, Transactions
>    Affects Versions: 4.0.0
>            Reporter: Sankar Hariappan
>            Assignee: Ashutosh Bapat
>            Priority: Major
>              Labels: DR, pull-request-available, replication
>         Attachments: HIVE-21529.01.patch
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> If ACID/MM tables to be enabled (hive.repl.dump.include.acid.tables) on an existing repl
policy, then need to combine bootstrap dump of these tables along with the ongoing incremental
dump. 
>  Shall add a one time config "hive.repl.bootstrap.acid.tables" to include bootstrap in
the given dump.
> TheĀ support for hive.repl.bootstrap.cleanup.type for ACID tables to clean-up partially
bootstrapped tables in case of retry is already in place, thanks to the work done during external
tables. Need to test that it actually works.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message