hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (HIVE-21529) Hive support bootstrap of ACID/MM tables on an existing policy.
Date Sat, 13 Apr 2019 17:35:01 GMT

     [ https://issues.apache.org/jira/browse/HIVE-21529?focusedWorklogId=227201&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-227201
]

ASF GitHub Bot logged work on HIVE-21529:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 13/Apr/19 17:34
            Start Date: 13/Apr/19 17:34
    Worklog Time Spent: 10m 
      Work Description: sankarh commented on pull request #581: HIVE-21529 : Bootstrap ACID
tables as part of incremental dump.
URL: https://github.com/apache/hive/pull/581#discussion_r275125959
 
 

 ##########
 File path: ql/src/java/org/apache/hadoop/hive/ql/parse/repl/dump/events/AllocWriteIdHandler.java
 ##########
 @@ -35,6 +36,21 @@ AllocWriteIdMessage eventMessage(String stringRepresentation) {
   @Override
   public void handle(Context withinContext) throws Exception {
     LOG.info("Processing#{} ALLOC_WRITE_ID message : {}", fromEventId(), eventMessageAsJSON);
+
+    // If we are bootstrapping ACID table during an incremental dump, the events corresponding
to
+    // these ACID tables are not dumped. Hence we do not need to allocate any writeId on
the
+    // target and hence we do not need to dump these events.
+    if (withinContext.hiveConf.getBoolVar(HiveConf.ConfVars.REPL_BOOTSTRAP_ACID_TABLES))
{
+      return;
+    }
+
+    // Also only for testing, we do not include ACID tables in the dump (and replicate) if
config
+    // says so.
+    if (withinContext.hiveConf.getBoolVar(HiveConf.ConfVars.HIVE_IN_TEST_REPL) &&
 
 Review comment:
   Need not check HIVE_IN_TEST_REPL.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 227201)
    Time Spent: 3h 10m  (was: 3h)

> Hive support bootstrap of ACID/MM tables on an existing policy.
> ---------------------------------------------------------------
>
>                 Key: HIVE-21529
>                 URL: https://issues.apache.org/jira/browse/HIVE-21529
>             Project: Hive
>          Issue Type: Sub-task
>          Components: repl, Transactions
>    Affects Versions: 4.0.0
>            Reporter: Sankar Hariappan
>            Assignee: Ashutosh Bapat
>            Priority: Major
>              Labels: DR, pull-request-available, replication
>         Attachments: HIVE-21529.01.patch, HIVE-21529.02.patch, HIVE-21529.03.patch
>
>          Time Spent: 3h 10m
>  Remaining Estimate: 0h
>
> If ACID/MM tables to be enabled (hive.repl.dump.include.acid.tables) on an existing repl
policy, then need to combine bootstrap dump of these tables along with the ongoing incremental
dump. 
>  Shall add a one time config "hive.repl.bootstrap.acid.tables" to include bootstrap in
the given dump.
> TheĀ support for hive.repl.bootstrap.cleanup.type for ACID tables to clean-up partially
bootstrapped tables in case of retry is already in place, thanks to the work done during external
tables. Need to test that it actually works.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message