hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (HIVE-21732) Configurable injection of load for LLAP task execution
Date Fri, 17 May 2019 18:38:00 GMT

     [ https://issues.apache.org/jira/browse/HIVE-21732?focusedWorklogId=244185&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-244185
]

ASF GitHub Bot logged work on HIVE-21732:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 17/May/19 18:37
            Start Date: 17/May/19 18:37
    Worklog Time Spent: 10m 
      Work Description: pvary commented on pull request #634: HIVE-21732: Configurable injection
of latency for LLAP task execution
URL: https://github.com/apache/hive/pull/634#discussion_r285240034
 
 

 ##########
 File path: common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
 ##########
 @@ -627,6 +627,14 @@ private static void populateLlapDaemonVarsSet(Set<String> llapDaemonVarsSetLocal
         "internal usage only, used only in test mode. If set false, the operation logs, and
the " +
         "operation log directory will not be removed, so they can be found after the test
runs."),
 
+    HIVE_TEST_LOAD_ENABLED("hive.test.load.enabled", false,
 
 Review comment:
   I am not experienced enough with HIVE_IN_TEST. What I see is that it is used widely around
Hive and I am afraid that reusing that config we modify the behavior seriously enough to invalidate
our test results. Can we be reasonably sure that it does not change anything seriously?
   
   I understand the desire to keep the number of config variables minimal, so I am open for
discussion. We might just use the host names to check if the load is needed - but this is
also not too elegant.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 244185)
    Time Spent: 1h 40m  (was: 1.5h)

> Configurable injection of load for LLAP task execution
> ------------------------------------------------------
>
>                 Key: HIVE-21732
>                 URL: https://issues.apache.org/jira/browse/HIVE-21732
>             Project: Hive
>          Issue Type: Test
>            Reporter: Peter Vary
>            Assignee: Peter Vary
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: HIVE-21732.2.patch, HIVE-21732.3.patch, HIVE-21732.4.patch, HIVE-21732.5.patch,
HIVE-21732.patch
>
>          Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> For evaluating testing, it would be good to have a configurable way to inject latency
for LLAP tasks.
> The configuration should be able to control how much latency is injected into each daemon.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message