hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (HIVE-21742) Vectorization: CASE result type casting
Date Sat, 01 Jun 2019 00:19:01 GMT

     [ https://issues.apache.org/jira/browse/HIVE-21742?focusedWorklogId=252144&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-252144
]

ASF GitHub Bot logged work on HIVE-21742:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 01/Jun/19 00:18
            Start Date: 01/Jun/19 00:18
    Worklog Time Spent: 10m 
      Work Description: t3rmin4t0r commented on pull request #656: HIVE-21742 : Vectorization:
CASE result type casting
URL: https://github.com/apache/hive/pull/656#discussion_r289582463
 
 

 ##########
 File path: ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java
 ##########
 @@ -1274,6 +1274,40 @@ protected ExprNodeDesc getXpathOrFuncExprNodeDesc(ASTNode expr,
               children);
         }
 
+        // introduce cast for expressions which are of different type than parent WHEN expr's
type
+        // this is done so that vectorization is able to vectorize appropriately
+        if (genericUDF instanceof GenericUDFWhen && desc instanceof ExprNodeGenericFuncDesc)
{
+          String castTypeName = desc.getTypeInfo().getTypeName();
+          if (desc.getTypeInfo() instanceof DecimalTypeInfo) {
+            castTypeName = serdeConstants.DECIMAL_TYPE_NAME;
+          }
+          FunctionInfo castFun = FunctionRegistry.getFunctionInfo(castTypeName);
+
+          String whenTypeName = desc.getTypeInfo().getTypeName();
+          List<ExprNodeDesc> updatedChildren = new ArrayList<>();
+          if (castFun != null) {
+            GenericUDF castUDF = castFun.getGenericUDF();
+            if (desc.getTypeInfo() instanceof DecimalTypeInfo || desc
+                .getTypeInfo() instanceof VarcharTypeInfo || desc
+                .getTypeInfo() instanceof CharTypeInfo || desc
+                .getTypeInfo() instanceof TimestampLocalTZTypeInfo) {
+              ((SettableUDF) castUDF).setTypeInfo(desc.getTypeInfo());
+            }
+            for (int i = 0; i < desc.getChildren().size(); i++) {
+              ExprNodeDesc child = children.get(i);
+              ExprNodeDesc newChild = child;
+              if ((i % 2 == 1 || i == desc.getChildren().size() - 1) && !whenTypeName
 
 Review comment:
   Does typeName have the scale/precision?
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 252144)
    Time Spent: 50m  (was: 40m)

> Vectorization: CASE result type casting
> ---------------------------------------
>
>                 Key: HIVE-21742
>                 URL: https://issues.apache.org/jira/browse/HIVE-21742
>             Project: Hive
>          Issue Type: Bug
>          Components: Logical Optimizer, Vectorization
>    Affects Versions: 3.1.1
>            Reporter: Gopal V
>            Assignee: Vineet Garg
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: HIVE-21742.1.patch, HIVE-21742.2.patch, HIVE-21742.3.patch
>
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> {code}
> create temporary table foo(q548284 int);
> insert into foo values(1),(2),(3),(4),(5),(6);
> select q548284, CASE WHEN ((q548284 = 1)) THEN (0.2) WHEN ((q548284 = 2)) THEN (0.4)
WHEN ((q548284 = 3)) THEN (0.6) WHEN ((q548284 = 4)) THEN (0.8) WHEN ((q548284 = 5)) THEN
(1) ELSE (null) END from foo order by q548284 limit 1;
> {code}
> Fails with 
> {code}
> Caused by: java.lang.ClassCastException: org.apache.hadoop.hive.ql.exec.vector.LongColumnVector
cannot be cast to org.apache.hadoop.hive.ql.exec.vector.DecimalColumnVector
>         at org.apache.hadoop.hive.ql.exec.vector.DecimalColumnVector.setElement(DecimalColumnVector.java:130)
>         at org.apache.hadoop.hive.ql.exec.vector.expressions.IfExprColumnNull.evaluate(IfExprColumnNull.java:101)
> {code}
> This gets fixed if the case return of (1) is turned into a (1.0).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message