hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-21753) Update HiveMetastore authorization to enable use of HiveAuthorizer implementation
Date Sun, 02 Jun 2019 19:52:01 GMT

    [ https://issues.apache.org/jira/browse/HIVE-21753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16854092#comment-16854092
] 

Hive QA commented on HIVE-21753:
--------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  0s{color} |
{color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  9m 56s{color}
| {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 23s{color} |
{color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 47s{color}
| {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  4m 44s{color} | {color:blue}
ql in master has 2259 extant Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 12s{color} |
{color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 41s{color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 21s{color} |
{color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m 21s{color} | {color:green}
the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 50s{color} | {color:red}
ql: The patch generated 254 new + 13 unchanged - 0 fixed = 267 total (was 13) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m  0s{color}
| {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  5m  5s{color} | {color:red}
ql generated 2 new + 2259 unchanged - 0 fixed = 2261 total (was 2259) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 12s{color} |
{color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 17s{color}
| {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 29m  0s{color} | {color:black}
{color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:ql |
|  |  Switch statement found in org.apache.hadoop.hive.ql.security.authorization.plugin.metastore.HiveMetaStoreAuthorizer.isViewOperation(PreEventContext)
where default case is missing  At HiveMetaStoreAuthorizer.java:where default case is missing
 At HiveMetaStoreAuthorizer.java:[lines 212-227] |
|  |  Redundant nullcheck of database, which is known to be non-null in org.apache.hadoop.hive.ql.security.authorization.plugin.metastore.events.AlterDatabaseEvent.getOutputHObjs()
 Redundant null check at AlterDatabaseEvent.java:is known to be non-null in org.apache.hadoop.hive.ql.security.authorization.plugin.metastore.events.AlterDatabaseEvent.getOutputHObjs()
 Redundant null check at AlterDatabaseEvent.java:[line 84] |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19)
x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-17391/dev-support/hive-personality.sh
|
| git revision | master / 22371f5 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-17391/yetus/diff-checkstyle-ql.txt
|
| findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-17391/yetus/new-findbugs-ql.html
|
| modules | C: ql U: ql |
| Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-17391/yetus.txt |
| Powered by | Apache Yetus    http://yetus.apache.org |


This message was automatically generated.



> Update HiveMetastore authorization to enable use of HiveAuthorizer implementation
> ---------------------------------------------------------------------------------
>
>                 Key: HIVE-21753
>                 URL: https://issues.apache.org/jira/browse/HIVE-21753
>             Project: Hive
>          Issue Type: Bug
>          Components: Hive
>    Affects Versions: 3.1.2
>            Reporter: Ramesh Mani
>            Assignee: Ramesh Mani
>            Priority: Critical
>              Labels: pull-request-available
>         Attachments: HIVE-21753.1.patch, HIVE-21753.2.patch, HIVE-21753.3.patch, HIVE-21753.4.patch,
HIVE-21753.5.patch, HIVE-21753.6.patch, HIVE-21753.7.patch
>
>          Time Spent: 5h 40m
>  Remaining Estimate: 0h
>
> Currently HMS supports authorization using StorageBasedAuthorizationProvider which relies
on permissions at filesystem – like HDFS. Hive supports a pluggable authorization interface,
and multiple authorizer implementations (like SQLStd, Ranger, Sentry) are available to authorizer
access in Hive. Extending HiveMetastore to use the same authorization interface as Hive will
enable use of pluggable authorization implementations; and will result in consistent authorization
across Hive, HMS and other services that use HMS (like Spark).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message