hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-21816) HMS Translation: Refactor tests to work with ACID tables.
Date Sat, 01 Jun 2019 00:14:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-21816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16853493#comment-16853493
] 

Hive QA commented on HIVE-21816:
--------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  0s{color} |
{color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  2m 15s{color} | {color:blue}
Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  8m 35s{color}
| {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 34s{color} |
{color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 58s{color}
| {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  1m 24s{color} | {color:blue}
standalone-metastore/metastore-server in master has 183 extant Findbugs warnings. {color}
|
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 49s{color} | {color:blue}
itests/hive-unit in master has 2 extant Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 56s{color} |
{color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 36s{color} | {color:blue}
Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 27s{color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 23s{color} |
{color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m 23s{color} | {color:green}
the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 32s{color} | {color:red}
standalone-metastore/metastore-server: The patch generated 90 new + 842 unchanged - 153 fixed
= 932 total (was 995) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 23s{color} | {color:red}
itests/hive-unit: The patch generated 133 new + 0 unchanged - 0 fixed = 133 total (was 0)
{color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m  0s{color}
| {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  1m 37s{color} | {color:red}
standalone-metastore/metastore-server generated 1 new + 183 unchanged - 0 fixed = 184 total
(was 183) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 55s{color} |
{color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 15s{color}
| {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 25m 19s{color} | {color:black}
{color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:standalone-metastore/metastore-server |
|  |  Redundant nullcheck of txnal, which is known to be non-null in org.apache.hadoop.hive.metastore.MetastoreDefaultTransformer.transform(List,
List, String)  Redundant null check at MetastoreDefaultTransformer.java:is known to be non-null
in org.apache.hadoop.hive.metastore.MetastoreDefaultTransformer.transform(List, List, String)
 Redundant null check at MetastoreDefaultTransformer.java:[line 275] |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19)
x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-17379/dev-support/hive-personality.sh
|
| git revision | master / 81117db |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-17379/yetus/diff-checkstyle-standalone-metastore_metastore-server.txt
|
| checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-17379/yetus/diff-checkstyle-itests_hive-unit.txt
|
| findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-17379/yetus/new-findbugs-standalone-metastore_metastore-server.html
|
| modules | C: standalone-metastore/metastore-server itests/hive-unit U: . |
| Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-17379/yetus.txt |
| Powered by | Apache Yetus    http://yetus.apache.org |


This message was automatically generated.



> HMS Translation: Refactor tests to work with ACID tables.
> ---------------------------------------------------------
>
>                 Key: HIVE-21816
>                 URL: https://issues.apache.org/jira/browse/HIVE-21816
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Hive
>    Affects Versions: 4.0.0
>            Reporter: Naveen Gangam
>            Assignee: Naveen Gangam
>            Priority: Major
>         Attachments: HIVE-21816.patch
>
>
> 1) TestHiveMetaStore unit tests does not work for full ACID tables as the TransactionalValidationListener
enforces that this table use AcidIO. The Orc IO files are only included in the hive-exec jars
that are not used by tests under standalone-metastore module. Even adding a test-scoped dependency
on hive-exec did not work. I had to relocate these tests into itests.
> 2) Implementation of logic that allows skipping of translation via the use of "MANAGERAWMETADATA"
capability.
> 3) Fixed some test bugs as the test was not failing originally when the createTable failed
because of the issue in #1. As a result, about 3 tests never ran fully and never failed. The
tests now fail if there are issues.
> 4) Refactoring of the code in the DefaultTransformer to make static lists of capabilities.
The return capabilities now is dependent on the table capabilities, the processor capabilities
and the accessType assigned to the table.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message