hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (HIVE-21864) LlapBaseInputFormat#closeAll() throws ConcurrentModificationException
Date Wed, 12 Jun 2019 13:12:00 GMT

     [ https://issues.apache.org/jira/browse/HIVE-21864?focusedWorklogId=258699&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-258699
]

ASF GitHub Bot logged work on HIVE-21864:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 12/Jun/19 13:11
            Start Date: 12/Jun/19 13:11
    Worklog Time Spent: 10m 
      Work Description: ShubhamChaurasia commented on pull request #669: HIVE-21864: LlapBaseInputFormat#closeAll()
throws ConcurrentModificationException
URL: https://github.com/apache/hive/pull/669#discussion_r292904914
 
 

 ##########
 File path: llap-ext-client/src/java/org/apache/hadoop/hive/llap/LlapBaseInputFormat.java
 ##########
 @@ -345,8 +346,11 @@ public static void close(String handleId) throws IOException {
    */
   public static void closeAll() {
     LOG.debug("Closing all handles");
-    for (String handleId : connectionMap.keySet()) {
+    Iterator<String> handleIds = connectionMap.keySet().iterator();
+    String handleId = null;
+    while (handleIds.hasNext()) {
       try {
+        handleId = handleIds.next();
 
 Review comment:
   Thanks Ashutosh, good catch. 
   I just realized, even without doing all these changes we can avoid it by just changing
the original code `for (String handleId : connectionMap.keySet())` 
   to `for (String handleId : new ArrayList<>(connectionMap.keySet()))`
   
   Looks good?
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 258699)
    Time Spent: 0.5h  (was: 20m)

> LlapBaseInputFormat#closeAll() throws ConcurrentModificationException
> ---------------------------------------------------------------------
>
>                 Key: HIVE-21864
>                 URL: https://issues.apache.org/jira/browse/HIVE-21864
>             Project: Hive
>          Issue Type: Bug
>          Components: llap
>    Affects Versions: 3.1.1
>            Reporter: Shubham Chaurasia
>            Assignee: Shubham Chaurasia
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: HIVE-21864.1.patch
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message