hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-22046) Differentiate among column stats computed by different engines
Date Fri, 26 Jul 2019 11:03:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-22046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16893726#comment-16893726
] 

Hive QA commented on HIVE-22046:
--------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  0s{color} |
{color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  1m 40s{color} | {color:blue}
Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  7m 11s{color}
| {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  3m 18s{color} |
{color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  2m 19s{color}
| {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  2m 34s{color} | {color:blue}
standalone-metastore/metastore-common in master has 31 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  1m 17s{color} | {color:blue}
standalone-metastore/metastore-server in master has 179 extant Findbugs warnings. {color}
|
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  4m 11s{color} | {color:blue}
ql in master has 2250 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 39s{color} | {color:blue}
itests/hive-unit in master has 2 extant Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  3m 16s{color} |
{color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 25s{color} | {color:blue}
Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  3m 49s{color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  3m 26s{color} |
{color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  3m 26s{color} | {color:green}
the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 14s{color} | {color:red}
standalone-metastore/metastore-common: The patch generated 9 new + 409 unchanged - 8 fixed
= 418 total (was 417) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 36s{color} | {color:red}
standalone-metastore/metastore-server: The patch generated 74 new + 1928 unchanged - 38 fixed
= 2002 total (was 1966) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 49s{color} | {color:red}
ql: The patch generated 5 new + 1127 unchanged - 3 fixed = 1132 total (was 1130) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 10s{color} | {color:red}
itests/hcatalog-unit: The patch generated 3 new + 26 unchanged - 1 fixed = 29 total (was 27)
{color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 20s{color} | {color:red}
itests/hive-unit: The patch generated 7 new + 300 unchanged - 1 fixed = 307 total (was 301)
{color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m  0s{color}
| {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  1m 28s{color} | {color:red}
standalone-metastore/metastore-server generated 2 new + 177 unchanged - 2 fixed = 179 total
(was 179) {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red}  1m 44s{color} | {color:red}
standalone-metastore_metastore-common generated 2 new + 47 unchanged - 0 fixed = 49 total
(was 47) {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 15s{color}
| {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 52m  6s{color} | {color:black}
{color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:standalone-metastore/metastore-server |
|  |  instanceof will always return false in org.apache.hadoop.hive.metastore.ObjectStore.getMPartitionColumnStatistics(Table,
List, List, Integer, ObjectStore$QueryWrapper), since a RuntimeException can't be a org.apache.hadoop.hive.metastore.api.MetaException
 At ObjectStore.java:in org.apache.hadoop.hive.metastore.ObjectStore.getMPartitionColumnStatistics(Table,
List, List, Integer, ObjectStore$QueryWrapper), since a RuntimeException can't be a org.apache.hadoop.hive.metastore.api.MetaException
 At ObjectStore.java:[line 9110] |
|  |  org.apache.hadoop.hive.metastore.ObjectStore.getMPartitionColumnStatistics(Table, List,
List, Integer, ObjectStore$QueryWrapper) concatenates strings using + in a loop  At ObjectStore.java:concatenates
strings using + in a loop  At ObjectStore.java:[line 9088] |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19)
x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-18174/dev-support/hive-personality.sh
|
| git revision | master / f7f7c58 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-18174/yetus/diff-checkstyle-standalone-metastore_metastore-common.txt
|
| checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-18174/yetus/diff-checkstyle-standalone-metastore_metastore-server.txt
|
| checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-18174/yetus/diff-checkstyle-ql.txt
|
| checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-18174/yetus/diff-checkstyle-itests_hcatalog-unit.txt
|
| checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-18174/yetus/diff-checkstyle-itests_hive-unit.txt
|
| findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-18174/yetus/new-findbugs-standalone-metastore_metastore-server.html
|
| javadoc | http://104.198.109.242/logs//PreCommit-HIVE-Build-18174/yetus/diff-javadoc-javadoc-standalone-metastore_metastore-common.txt
|
| modules | C: standalone-metastore/metastore-common metastore standalone-metastore/metastore-server
ql itests/hcatalog-unit itests/hive-unit U: . |
| Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-18174/yetus.txt |
| Powered by | Apache Yetus    http://yetus.apache.org |


This message was automatically generated.



> Differentiate among column stats computed by different engines
> --------------------------------------------------------------
>
>                 Key: HIVE-22046
>                 URL: https://issues.apache.org/jira/browse/HIVE-22046
>             Project: Hive
>          Issue Type: Improvement
>          Components: Metastore
>            Reporter: Jesus Camacho Rodriguez
>            Assignee: Jesus Camacho Rodriguez
>            Priority: Major
>         Attachments: HIVE-22046.01.patch, HIVE-22046.02.patch, HIVE-22046.03.patch, HIVE-22046.patch
>
>
> The goal is to avoid computation of column stats by engines to step on each other, e.g.,
Hive and Impala. In longer term, we may introduce a common representation for the column statistics
stored by different engines.
> For this issue, we will add a new column 'engine' to TAB_COL_STATS HMS table (unpartitioned
tables) and to PART_COL_STATS HMS table (partitioned tables). This will prevent conflicts
at the column level stats.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Mime
View raw message