hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (Jira)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-21114) Create read-only transactions
Date Fri, 01 Nov 2019 03:45:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-21114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16964577#comment-16964577
] 

Hive QA commented on HIVE-21114:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12984504/HIVE-21114.10.patch

{color:green}SUCCESS:{color} +1 due to 3 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 17566 tests executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.metastore.TestPartitionManagement.testPartitionDiscoveryTransactionalTable
(batchId=223)
{noformat}

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/19242/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/19242/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-19242/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 1 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12984504 - PreCommit-HIVE-Build

> Create read-only transactions
> -----------------------------
>
>                 Key: HIVE-21114
>                 URL: https://issues.apache.org/jira/browse/HIVE-21114
>             Project: Hive
>          Issue Type: Bug
>          Components: Transactions
>    Affects Versions: 4.0.0
>            Reporter: Eugene Koifman
>            Assignee: Denys Kuzmenko
>            Priority: Major
>         Attachments: HIVE-21114.1.patch, HIVE-21114.10.patch, HIVE-21114.2.patch, HIVE-21114.3.patch,
HIVE-21114.4.patch, HIVE-21114.5.patch, HIVE-21114.6.patch, HIVE-21114.7.patch, HIVE-21114.8.patch,
HIVE-21114.9.patch
>
>
> With HIVE-21036 we have a way to indicate that a txn is read only.
> We should (at least in auto-commit mode) determine if the single stmt is a read and mark
the txn accordingly.  
> Then we can optimize {{TxnHandler.commitTxn()}} so that it doesn't do any checks in write_set
etc.
> {{TxnHandler.commitTxn()}} already starts with {{lockTransactionRecord(stmt, txnid, TXN_OPEN)}}
so it can read the txn type in the same SQL stmt.
> HiveOperation only has QUERY, which includes Insert and Select, so this requires figuring
out how to determine if a query is a SELECT.  By the time {{Driver.openTransaction();}} is
called, we have already parsed the query so there should be a way to know if the statement
only reads.
> For multi-stmt txns (once these are supported) we should allow user to indicate that
a txn is read-only and then not allow any statements that can make modifications in this txn.
 This should be a different jira.
> cc [~ikryvenko]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message