hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (Jira)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-22325) variable expansion doesn't work in beeline-site.xml
Date Fri, 01 Nov 2019 05:39:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-22325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16964621#comment-16964621
] 

Hive QA commented on HIVE-22325:
--------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  0s{color} |
{color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  8m 47s{color}
| {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 22s{color} |
{color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 12s{color}
| {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 30s{color} | {color:blue}
beeline in master has 48 extant Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 12s{color} |
{color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 19s{color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 21s{color} |
{color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 21s{color} | {color:green}
the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 12s{color} | {color:red}
beeline: The patch generated 13 new + 15 unchanged - 0 fixed = 28 total (was 15) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m  0s{color}
| {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} xml {color} | {color:red}  0m  2s{color} | {color:red}
The patch has 1 ill-formed XML file(s). {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 37s{color} |
{color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 13s{color} |
{color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 15s{color}
| {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 12m 33s{color} | {color:black}
{color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  xml  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19)
x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-19245/dev-support/hive-personality.sh
|
| git revision | master / 9490264 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.1 |
| checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-19245/yetus/diff-checkstyle-beeline.txt
|
| xml | http://104.198.109.242/logs//PreCommit-HIVE-Build-19245/yetus/xml.txt |
| modules | C: beeline U: beeline |
| Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-19245/yetus.txt |
| Powered by | Apache Yetus    http://yetus.apache.org |


This message was automatically generated.



> variable expansion doesn't work in beeline-site.xml
> ---------------------------------------------------
>
>                 Key: HIVE-22325
>                 URL: https://issues.apache.org/jira/browse/HIVE-22325
>             Project: Hive
>          Issue Type: Bug
>          Components: Beeline
>    Affects Versions: 3.1.0, 3.1.1, 3.1.2
>            Reporter: Allan Espinosa
>            Assignee: Allan Espinosa
>            Priority: Major
>         Attachments: HIVE-22325.patch.txt
>
>
> I have a default jdbc connection string and I want to build on top on it to have customized
connections like setting custom queue names.  
> {code}
> $ cat .beeline/beeline-site.xml
>   <configuration  xmlns:xi="http://www.w3.org/2001/XInclude">
>     <property>
>       <name>beeline.hs2.jdbc.url.base</name>
>       <value>jdbc:hive2://localhost/</value>
>     </property>
>     <property>
>       <name>beeline.hs2.jdbc.url.myqueue</name>
>       <value>${beeline.hs2.jdbc.url.base}?tez.queue.name=myqueue</value>
>     </property>
>   </configuration>
> $ beeline -c myqueue
> SLF4J: Class path contains multiple SLF4J bindings.
> SLF4J: Found binding in [jar:file:/usr/hdp/3.1.0.0-78/hive/lib/log4j-slf4j-impl-2.10.0.jar!/org/slf4j/impl/StaticLoggerBinder.class]
> SLF4J: Found binding in [jar:file:/usr/hdp/3.1.0.0-78/hadoop/lib/slf4j-log4j12-1.7.25.jar!/org/slf4j/impl/StaticLoggerBinder.class]
> SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation.
> SLF4J: Actual binding is of type [org.apache.logging.slf4j.Log4jLoggerFactory]
> Error in parsing jdbc url: ${beeline.hs2.jdbc.url.base}?tez.queue.name=myqueue from beeline-site.xml
> Beeline version 3.1.0.3.1.0.0-78 by Apache Hive
> beeline>
> {code}
> Relevant code is found in https://github.com/apache/hive/blob/master/beeline/src/java/org/apache/hive/beeline/hs2connection/BeelineSiteParser.java#L94
> Entry<T,T>#getValue() skips the variable expansion .  Using Configuration#get(key)
would make this work.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message