hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <j...@apache.org>
Subject [jira] [Work logged] (HIVE-22736) Support replication across multiple encryption zones
Date Mon, 03 Feb 2020 04:31:00 GMT

     [ https://issues.apache.org/jira/browse/HIVE-22736?focusedWorklogId=380683&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-380683
]

ASF GitHub Bot logged work on HIVE-22736:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 03/Feb/20 04:30
            Start Date: 03/Feb/20 04:30
    Worklog Time Spent: 10m 
      Work Description: maheshk114 commented on pull request #883: HIVE-22736 Support multiple
encryption zones in replication
URL: https://github.com/apache/hive/pull/883#discussion_r373918256
 
 

 ##########
 File path: standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/ReplChangeManager.java
 ##########
 @@ -156,13 +157,21 @@ private ReplChangeManager(Configuration conf) throws MetaException
{
           //Create default cm root
           Path cmroot = new Path(cmRootDir);
           createCmRoot(cmroot);
+          FileSystem cmRootFs = cmroot.getFileSystem(conf);
           HdfsEncryptionShim pathEncryptionShim = hadoopShims
-                  .createHdfsEncryptionShim(cmroot.getFileSystem(conf), conf);
+                  .createHdfsEncryptionShim(cmRootFs, conf);
           if (pathEncryptionShim.isPathEncrypted(cmroot)) {
-            String encryptionZonePath = pathEncryptionShim.getEncryptionZoneForPath(cmroot).getPath();
-            encryptionZones.put(encryptionZonePath, cmroot);
+            //cm root cannot be encrypted. So we move the current cmroot data to a cmroot
in a encrypted zone
+            String encryptionZonePath = cmRootFs.getUri()
+                    + pathEncryptionShim.getEncryptionZoneForPath(cmroot).getPath();
+            cmRootFs.rename(cmroot, new Path(encryptionZonePath + encryptedCmRootDir));
 
 Review comment:
   move will cause issue if some repl dumps are already there with old cm path 
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 380683)
    Time Spent: 3h  (was: 2h 50m)

> Support replication across multiple encryption zones
> ----------------------------------------------------
>
>                 Key: HIVE-22736
>                 URL: https://issues.apache.org/jira/browse/HIVE-22736
>             Project: Hive
>          Issue Type: Task
>            Reporter: Aasha Medhi
>            Assignee: Aasha Medhi
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: HIVE-22736.patch, HIVE-22736.patch, HIVE-22736.patch, HIVE-22736.patch,
HIVE-22736.patch, HIVE-22736.patch, HIVE-22736.patch, HIVE-22736.patch, HIVE-22736.patch,
HIVE-22736.patch, HIVE-22736.patch, HIVE-22736.patch, HIVE-22736.patch, HIVE-22736.patch,
HIVE-22736.patch, HIVE-22736.patch, HIVE-22736.patch, HIVE-22736.patch, HIVE-22736.patch,
HIVE-22736.patch, HIVE-22736.patch
>
>          Time Spent: 3h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message