hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <j...@apache.org>
Subject [jira] [Work logged] (HIVE-22747) Break up DDLSemanticAnalyzer - extract Table info and lock analyzers
Date Tue, 11 Feb 2020 15:55:00 GMT

     [ https://issues.apache.org/jira/browse/HIVE-22747?focusedWorklogId=385244&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-385244
]

ASF GitHub Bot logged work on HIVE-22747:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 11/Feb/20 15:54
            Start Date: 11/Feb/20 15:54
    Worklog Time Spent: 10m 
      Work Description: kgyrtkirk commented on pull request #882: HIVE-22747 Break up DDLSemanticAnalyzer
- extract Table info and lock analyzers
URL: https://github.com/apache/hive/pull/882#discussion_r377707866
 
 

 ##########
 File path: ql/src/java/org/apache/hadoop/hive/ql/ddl/DDLUtils.java
 ##########
 @@ -219,4 +220,21 @@ private static String getHS2Host(HiveConf conf) throws SemanticException
{
 
     throw new SemanticException("Kill query is only supported in HiveServer2 (not hive cli)");
   }
+
+  /**
+   * Get the fully qualified name in the node.
+   * E.g. the node of the form ^(DOT ^(DOT a b) c) will generate a name of the form "a.b.c".
+   */
+  public static String getFQName(ASTNode node) {
 
 Review comment:
   I don't believe this method will work correctly for quoted cases like:
   ```
   `db`.`table` 
   ```
   right now I don't see the original place where this was...
   ...it work just like before?
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 385244)
    Time Spent: 20m  (was: 10m)

> Break up DDLSemanticAnalyzer - extract Table info and lock analyzers
> --------------------------------------------------------------------
>
>                 Key: HIVE-22747
>                 URL: https://issues.apache.org/jira/browse/HIVE-22747
>             Project: Hive
>          Issue Type: Sub-task
>            Reporter: Miklos Gergely
>            Assignee: Miklos Gergely
>            Priority: Major
>              Labels: pull-request-available, refactor-ddl
>         Attachments: HIVE-22747.01.patch, HIVE-22747.02.patch
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> DDLSemanticAnalyzer is a huge class, more than 4000 lines long. The goal is to refactor
it in order to have everything cut into more handleable classes under the packageĀ  org.apache.hadoop.hive.ql.exec.ddl:
>  * have a separate class for each analyzers
>  * have a package for each operation, containing an analyzer, a description, and an operation,
so the amount of classes under a package is more manageable
> Step #13: extract the table info and lock related analyzers from DDLSemanticAnalyzer,
and move them under the new package.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message