hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From László Pintér (Jira) <j...@apache.org>
Subject [jira] [Commented] (HIVE-22862) Remove unnecessary calls to isEnoughToCompact
Date Mon, 17 Feb 2020 13:41:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-22862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17038358#comment-17038358
] 

László Pintér commented on HIVE-22862:
--------------------------------------

One minor thing. Since, from now on the only place where isEnoughToCompact is called, is in
Worker, could you move this method to Worker class? QueryCompactor.Util is meant to collect
all the methods which are useful for QueryCompactor and its subclasses. 

> Remove unnecessary calls to isEnoughToCompact
> ---------------------------------------------
>
>                 Key: HIVE-22862
>                 URL: https://issues.apache.org/jira/browse/HIVE-22862
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Karen Coppage
>            Assignee: Karen Coppage
>            Priority: Minor
>         Attachments: HIVE-22862.01.patch, HIVE-22862.01.patch
>
>
> QueryCompactor.Util#isEnoughToCompact is called in Worker#run once before any sort of
compaction is run, after this it is called in 3 other places during compaction unnecessarily. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message