hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (Jira)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-22750) Consolidate LockType naming
Date Sat, 04 Apr 2020 04:42:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-22750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17075027#comment-17075027
] 

Hive QA commented on HIVE-22750:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12998771/HIVE-22750.4.patch

{color:green}SUCCESS:{color} +1 due to 7 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 5 failed/errored test(s), 18173 tests executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[lock1] (batchId=8)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[lock2] (batchId=35)
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver[insert_into4] (batchId=106)
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver[lockneg_try_db_lock_conflict]
(batchId=106)
org.apache.hive.beeline.TestBeeLineWithArgs.testRowsAffected (batchId=286)
{noformat}

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/21431/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/21431/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-21431/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 5 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12998771 - PreCommit-HIVE-Build

> Consolidate LockType naming
> ---------------------------
>
>                 Key: HIVE-22750
>                 URL: https://issues.apache.org/jira/browse/HIVE-22750
>             Project: Hive
>          Issue Type: Improvement
>          Components: Transactions
>            Reporter: Zoltan Chovan
>            Assignee: Marton Bod
>            Priority: Minor
>         Attachments: HIVE-22750.1.patch, HIVE-22750.2.patch, HIVE-22750.3.patch, HIVE-22750.4.patch
>
>
> Extend enum with string literal to remove unnecessary `id` to `char` casting for the
LockType:
> {code:java}
> switch (lockType) {
>             case EXCLUSIVE:
>               lockChar = LOCK_EXCLUSIVE;
>               break;
>             case SHARED_READ:
>               lockChar = LOCK_SHARED;
>               break;
>             case SHARED_WRITE:
>               lockChar = LOCK_SEMI_SHARED;
>               break;
>           }
> {code}
> Consolidate LockType naming in code and schema upgrade scripts:
> {code:java}
> CASE WHEN HL.`HL_LOCK_TYPE` = 'e' THEN 'exclusive' WHEN HL.`HL_LOCK_TYPE` = 'r' THEN
'shared' WHEN HL.`HL_LOCK_TYPE` = 'w' THEN *'semi-shared'* END AS LOCK_TYPE,
> {code}
> +*Lock types:*+
> EXCLUSIVE
>  EXCL_WRITE
>  SHARED_WRITE
>  SHARED_READ



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message