hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <j...@apache.org>
Subject [jira] [Work logged] (HIVE-23095) NDV might be overestimated for a table with ~70 value
Date Sat, 04 Apr 2020 01:00:01 GMT

     [ https://issues.apache.org/jira/browse/HIVE-23095?focusedWorklogId=415864&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-415864
]

ASF GitHub Bot logged work on HIVE-23095:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 04/Apr/20 00:59
            Start Date: 04/Apr/20 00:59
    Worklog Time Spent: 10m 
      Work Description: prasanthj commented on pull request #964: HIVE-23095 ndv 70
URL: https://github.com/apache/hive/pull/964#discussion_r403398823
 
 

 ##########
 File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/common/ndv/hll/HLLSparseRegister.java
 ##########
 @@ -195,7 +199,7 @@ public void extractLowBitsTo(HLLRegister dest) {
       byte lr = entry.getValue(); // this can be a max of 65, never > 127
       if (lr != 0) {
         // should be a no-op for sparse
-        dest.add((long) ((1 << (p + lr - 1)) | idx));
+        dest.add((1 << (p + lr - 1)) | idx);
 
 Review comment:
   nit: just noticing this. To be safe wrt overflow can you make it `1L << (p + lr -
1)`
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 415864)

> NDV might be overestimated for a table with ~70 value
> -----------------------------------------------------
>
>                 Key: HIVE-23095
>                 URL: https://issues.apache.org/jira/browse/HIVE-23095
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Zoltan Haindrich
>            Assignee: Zoltan Haindrich
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: HIVE-23095.01.patch, HIVE-23095.02.patch, HIVE-23095.03.patch, HIVE-23095.04.patch,
HIVE-23095.04.patch, HIVE-23095.04.patch
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> uncovered during looking into HIVE-23082
> https://issues.apache.org/jira/browse/HIVE-23082?focusedCommentId=17067773&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17067773



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message