hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (Jira)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-21304) Make bucketing version usage more robust
Date Sun, 03 May 2020 23:31:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-21304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17098599#comment-17098599
] 

Hive QA commented on HIVE-21304:
--------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  0s{color} |
{color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  1m 29s{color} | {color:blue}
Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  7m 49s{color}
| {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 30s{color} |
{color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m  7s{color}
| {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  3m 39s{color} | {color:blue}
ql in master has 1530 extant Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 10s{color} |
{color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 27s{color} | {color:blue}
Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 57s{color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 33s{color} |
{color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m 33s{color} | {color:green}
the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 53s{color} | {color:red}
ql: The patch generated 6 new + 1312 unchanged - 12 fixed = 1318 total (was 1324) {color}
|
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m  0s{color}
| {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  3m 52s{color} | {color:red}
ql generated 1 new + 1530 unchanged - 0 fixed = 1531 total (was 1530) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 11s{color} |
{color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 14s{color}
| {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 28m 52s{color} | {color:black}
{color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:ql |
|  |  Nullcheck of table_desc at line 8064 of value previously dereferenced in org.apache.hadoop.hive.ql.parse.SemanticAnalyzer.createFileSinkDesc(String,
TableDesc, Partition, Path, int, boolean, boolean, boolean, Path, SemanticAnalyzer$SortBucketRSCtx,
DynamicPartitionCtx, ListBucketingCtx, RowSchema, boolean, Table, Long, boolean, Integer,
QB, boolean)  At SemanticAnalyzer.java:8064 of value previously dereferenced in org.apache.hadoop.hive.ql.parse.SemanticAnalyzer.createFileSinkDesc(String,
TableDesc, Partition, Path, int, boolean, boolean, boolean, Path, SemanticAnalyzer$SortBucketRSCtx,
DynamicPartitionCtx, ListBucketingCtx, RowSchema, boolean, Table, Long, boolean, Integer,
QB, boolean)  At SemanticAnalyzer.java:[line 8057] |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19)
x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-22104/dev-support/hive-personality.sh
|
| git revision | master / b283bbd |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.1 |
| checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-22104/yetus/diff-checkstyle-ql.txt
|
| findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-22104/yetus/new-findbugs-ql.html
|
| modules | C: ql itests itests/hive-blobstore U: . |
| Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-22104/yetus.txt |
| Powered by | Apache Yetus    http://yetus.apache.org |


This message was automatically generated.



> Make bucketing version usage more robust
> ----------------------------------------
>
>                 Key: HIVE-21304
>                 URL: https://issues.apache.org/jira/browse/HIVE-21304
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Deepak Jaiswal
>            Assignee: Zoltan Haindrich
>            Priority: Major
>         Attachments: HIVE-21304.01.patch, HIVE-21304.02.patch, HIVE-21304.03.patch, HIVE-21304.04.patch,
HIVE-21304.05.patch, HIVE-21304.06.patch, HIVE-21304.07.patch, HIVE-21304.08.patch, HIVE-21304.09.patch,
HIVE-21304.10.patch, HIVE-21304.11.patch, HIVE-21304.12.patch, HIVE-21304.13.patch, HIVE-21304.14.patch,
HIVE-21304.15.patch, HIVE-21304.16.patch, HIVE-21304.17.patch, HIVE-21304.18.patch, HIVE-21304.19.patch,
HIVE-21304.20.patch, HIVE-21304.21.patch, HIVE-21304.22.patch, HIVE-21304.23.patch, HIVE-21304.24.patch,
HIVE-21304.25.patch, HIVE-21304.26.patch, HIVE-21304.27.patch, HIVE-21304.28.patch, HIVE-21304.29.patch,
HIVE-21304.30.patch, HIVE-21304.31.patch, HIVE-21304.32.patch, HIVE-21304.33.patch, HIVE-21304.33.patch,
HIVE-21304.33.patch, HIVE-21304.34.patch, HIVE-21304.34.patch, HIVE-21304.35.patch, HIVE-21304.35.patch,
HIVE-21304.36.patch, HIVE-21304.37.patch, HIVE-21304.38.patch, HIVE-21304.38.patch, HIVE-21304.38.patch
>
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> * Show Bucketing version for ReduceSinkOp in explain extended plan - this helps identify
what hashing algorithm is being used by by ReduceSinkOp.
> * move the actually selected version to the "conf" so that it doesn't get lost
> * replace trait related logic with a separate optimizer rule
> * do version selection based on a group of operator - this is more reliable
> * skip bucketingversion selection for tables with 1 buckets
> * prefer to use version 2 if possible
> * fix operator creations which didn't set a new conf



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message