hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Mollitor (Jira)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-23108) Cleanup HiveBaseResultSet.java
Date Fri, 01 May 2020 13:40:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-23108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097372#comment-17097372
] 

David Mollitor commented on HIVE-23108:
---------------------------------------

[~pvary] Please review once more :) I added some unit tests and fixed the 'wasNull' situation
you pointed out

> Cleanup HiveBaseResultSet.java
> ------------------------------
>
>                 Key: HIVE-23108
>                 URL: https://issues.apache.org/jira/browse/HIVE-23108
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: David Mollitor
>            Assignee: David Mollitor
>            Priority: Minor
>         Attachments: HIVE-23108.1.patch, HIVE-23108.2.patch, HIVE-23108.3.patch, HIVE-23108.4.patch,
HIVE-23108.5.patch, HIVE-23108.5.patch, HIVE-23108.5.patch
>
>
> * Unify the code (there are several implementations of the same thing)
>  * Added better error messages
>  * In some cases, the code was throwing RuntimeExceptions which is against the JDBC Spec
>  * Make findColumn a bit more streamlined
>  * Remove non-javadoc comments
>  * Add {{@Override}} annotations where appropriate
>  * Formatting changes



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message