hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (Jira)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-23124) Review of SQLOperation Class
Date Fri, 01 May 2020 08:19:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-23124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097240#comment-17097240
] 

Hive QA commented on HIVE-23124:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/13001720/HIVE-23124.3.patch

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 17192 tests executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.metastore.txn.TestTxnHandler.testReplTimeouts (batchId=244)
{noformat}

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/22050/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/22050/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-22050/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 1 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 13001720 - PreCommit-HIVE-Build

> Review of SQLOperation Class
> ----------------------------
>
>                 Key: HIVE-23124
>                 URL: https://issues.apache.org/jira/browse/HIVE-23124
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: David Mollitor
>            Assignee: David Mollitor
>            Priority: Major
>         Attachments: HIVE-23124.1.patch, HIVE-23124.2.patch, HIVE-23124.3.patch, HIVE-23124.3.patch,
HIVE-23124.3.patch
>
>
> * Use ConcurrentHashMap instead of synchronized methods to improve multi-threaded access
>  * Use JDK 8 facilities where applicable
>  * General cleanup
>  * Better log messages and Exception messages
>  * Use {{switch}} statement instead of if/else blocks
>  * Checkstyle fixes



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message