hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (Jira)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-23133) Numeric operations can have different result across hardware archs
Date Tue, 12 May 2020 12:46:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-23133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17105393#comment-17105393
] 

Hive QA commented on HIVE-23133:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/13002694/HIVE-23133.5.patch

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 4 failed/errored test(s), 17265 tests executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCompareCliDriver.testCliDriver[vectorized_math_funcs] (batchId=229)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vectorized_math_funcs]
(batchId=54)
org.apache.hadoop.hive.ql.txn.compactor.TestWorker2.minorTableWithBase (batchId=256)
org.apache.hive.jdbc.TestActivePassiveHA.testActivePassiveHA (batchId=215)
{noformat}

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/22283/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/22283/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-22283/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 4 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 13002694 - PreCommit-HIVE-Build

> Numeric operations can have different result across hardware archs
> ------------------------------------------------------------------
>
>                 Key: HIVE-23133
>                 URL: https://issues.apache.org/jira/browse/HIVE-23133
>             Project: Hive
>          Issue Type: Sub-task
>            Reporter: Zhenyu Zheng
>            Assignee: Zhenyu Zheng
>            Priority: Major
>         Attachments: HIVE-23133.1.patch, HIVE-23133.2.patch, HIVE-23133.3.patch, HIVE-23133.4.patch,
HIVE-23133.5.patch
>
>
> Currently, we have set up an ARM CI to test out how Hive works on ARM platform:
> [https://builds.apache.org/view/H-L/view/Hive/job/Hive-linux-ARM-trunk/]
> Among the failures, we have observed that some numeric operations can have different
result across hardware archs, such as:
> [https://builds.apache.org/view/H-L/view/Hive/job/Hive-linux-ARM-trunk/25/testReport/org.apache.hadoop.hive.cli/TestCliDriver/testCliDriver_vector_decimal_udf2_/]
> [https://builds.apache.org/view/H-L/view/Hive/job/Hive-linux-ARM-trunk/25/testReport/org.apache.hadoop.hive.cli/TestSparkCliDriver/testCliDriver_subquery_select_/]
> [https://builds.apache.org/view/H-L/view/Hive/job/Hive-linux-ARM-trunk/25/testReport/org.apache.hadoop.hive.cli/TestSparkCliDriver/testCliDriver_vectorized_math_funcs_/]
> we can see that the calculation results of log, exp, cos, toRadians etc is slitly different
than the .out file results that we are
> comparing(they are tested and wrote on X86 machines), this is because of we use [Math
Library|https://docs.oracle.com/javase/6/docs/api/java/lang/Math.html] for these kind of calculations.
> and according to the [illustration|https://docs.oracle.com/javase/6/docs/api/java/lang/Math.html]:
> _Unlike some of the numeric methods of class StrictMath, all implementations of the equivalent
functions of class Math are not_
> _defined to return the bit-for-bit same results. This relaxation permits better-performing
implementations where strict reproducibility_
> _is not required._
> _By default many of the Math methods simply call the equivalent method in StrictMath
for their implementation._
> _Code generators are encouraged to use platform-specific native libraries or microprocessor
instructions, where available,_
> _to provide higher-performance implementations of Math methods._
> so the result will have difference across hardware archs.
> On the other hand, JAVA provided another library [StrictMath|https://docs.oracle.com/javase/6/docs/api/java/lang/StrictMath.html]
that will not have this kind of problem as according to its' [reference|https://docs.oracle.com/javase/6/docs/api/java/lang/StrictMath.html]:
> _To help ensure portability of Java programs, the definitions of some of the numeric
functions in this package require that they produce_
> _the same results as certain published algorithms._
> So in order to fix the above mentioned problem, we have to consider switch to use StrictMath
instead of Math.
>  
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message