hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (Jira)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-23354) Remove file size sanity checking from compareTempOrDuplicateFiles
Date Fri, 15 May 2020 11:28:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-23354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17108187#comment-17108187
] 

Hive QA commented on HIVE-23354:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/13002975/HIVE-23354.5.patch

{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 17269 tests executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[special_character_in_tabnames_1]
(batchId=78)
{noformat}

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/22353/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/22353/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-22353/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 1 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 13002975 - PreCommit-HIVE-Build

> Remove file size sanity checking from compareTempOrDuplicateFiles
> -----------------------------------------------------------------
>
>                 Key: HIVE-23354
>                 URL: https://issues.apache.org/jira/browse/HIVE-23354
>             Project: Hive
>          Issue Type: Bug
>          Components: HiveServer2
>            Reporter: John Sherman
>            Assignee: John Sherman
>            Priority: Major
>         Attachments: HIVE-23354.1.patch, HIVE-23354.2.patch, HIVE-23354.3.patch, HIVE-23354.4.patch,
HIVE-23354.5.patch
>
>
> [https://github.com/apache/hive/blob/cdd55aa319a3440963a886ebfff11cd2a240781d/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java#L1952-L2010]
>  compareTempOrDuplicateFiles uses a combination of attemptId and fileSize to determine
which file(s) to keep.
>  I've seen instances where this function throws an exception due to the fact that the
newer attemptId file size is less than the older attemptId (thus failing the query).
>  I think this assumption is faulty, due to various factors such as file compression and
the order in which values are written. It may be prudent to trust that the newest attemptId
is in fact the best choice.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message