hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (Jira)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-23443) LLAP speculative task pre-emption seems to be not working
Date Fri, 15 May 2020 10:16:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-23443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17108150#comment-17108150
] 

Hive QA commented on HIVE-23443:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/13002973/HIVE-23443.2.patch

{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 17270 tests executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestMiniDruidCliDriver.testCliDriver[druid_materialized_view_rewrite_ssb]
(batchId=128)
{noformat}

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/22352/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/22352/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-22352/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 1 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 13002973 - PreCommit-HIVE-Build

> LLAP speculative task pre-emption seems to be not working
> ---------------------------------------------------------
>
>                 Key: HIVE-23443
>                 URL: https://issues.apache.org/jira/browse/HIVE-23443
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Prasanth Jayachandran
>            Assignee: Prasanth Jayachandran
>            Priority: Major
>         Attachments: HIVE-23443.1.patch, HIVE-23443.2.patch
>
>
> I think after HIVE-23210 we are getting a stable sort order and it is causing pre-emption
to not work in certain cases.
> {code:java}
> "attempt_1589167813851_0000_119_01_000008_0 (hive_20200511055921_89598f09-19f1-4969-ab7a-82e2dd796273-119/Map
1, started at 2020-05-11 05:59:22, in preemption queue, can finish)", 
> "attempt_1589167813851_0008_84_01_000008_1 (hive_20200511055928_7ae29ca3-e67d-4d1f-b193-05651023b503-84/Map
1, started at 2020-05-11 06:00:23, in preemption queue, can finish)" {code}
> Scheduler only peek's at the pre-emption queue and looks at whether it is non-finishable. 
> [https://github.com/apache/hive/blob/master/llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/TaskExecutorService.java#L420]
> In the above case, all tasks are speculative but state change is not triggering pre-emption
queue re-ordering so peek() always returns canFinish task even though non-finishable tasks
are in the queue. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message