hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <j...@apache.org>
Subject [jira] [Work logged] (HIVE-19653) Incorrect predicate pushdown for groupby with grouping sets
Date Tue, 16 Jun 2020 16:56:01 GMT

     [ https://issues.apache.org/jira/browse/HIVE-19653?focusedWorklogId=446705&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-446705
]

ASF GitHub Bot logged work on HIVE-19653:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 16/Jun/20 16:55
            Start Date: 16/Jun/20 16:55
    Worklog Time Spent: 10m 
      Work Description: github-actions[bot] commented on pull request #354:
URL: https://github.com/apache/hive/pull/354#issuecomment-644886564


   This pull request has been automatically marked as stale because it has not had recent
activity. It will be closed if no further activity occurs.
   Feel free to reach out on the dev@hive.apache.org list if the patch is in need of reviews.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 446705)
    Time Spent: 1h 50m  (was: 1h 40m)

> Incorrect predicate pushdown for groupby with grouping sets
> -----------------------------------------------------------
>
>                 Key: HIVE-19653
>                 URL: https://issues.apache.org/jira/browse/HIVE-19653
>             Project: Hive
>          Issue Type: Bug
>          Components: Logical Optimizer
>            Reporter: Zhang Li
>            Assignee: Zhihua Deng
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 4.0.0
>
>         Attachments: HIVE-19653.1.patch, HIVE-19653.patch
>
>          Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> Consider the following query:
> {code:java}
> CREATE TABLE T1(a STRING, b STRING, s BIGINT);
> INSERT OVERWRITE TABLE T1 VALUES ('aaaa', 'bbbb', 123456);
> SELECT * FROM (
> SELECT a, b, sum(s)
> FROM T1
> GROUP BY a, b GROUPING SETS ((), (a), (b), (a, b))
> ) t WHERE a IS NOT NULL;
> {code}
> When hive.optimize.ppd is enabled (and hive.cbo.enable=false), the query will output:
> {code:java}
> NULL	NULL	123456
> NULL	bbbb	123456
> aaaa	NULL	123456
> aaaa	bbbb	123456
> {code}
> We can see the predicate "a IS NOT NULL" takes no effect, which is incorrect.
> When performing PPD optimization for a GBY operator, we should make sure all grouping
sets contains the processing expr before pushdown. otherwise the expr value after GBY is changed
and the result is wrong.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message