hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (Jira)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-22017) [ Interface changes ] Keep HMS interfaces backward compatible with changes for HIVE-21637
Date Tue, 02 Jun 2020 18:10:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-22017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17124163#comment-17124163
] 

Hive QA commented on HIVE-22017:
--------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  0s{color} |
{color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 23s{color} | {color:blue}
Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  9m  7s{color}
| {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 57s{color} |
{color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 40s{color}
| {color:green} master passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  0m 15s{color} | {color:red}
metastore-common in master failed. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  0m 14s{color} | {color:red}
metastore-server in master failed. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 22s{color} |
{color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m  8s{color} | {color:blue}
Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m  9s{color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 58s{color} |
{color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 58s{color} | {color:green}
the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 26s{color} | {color:red}
standalone-metastore/metastore-server: The patch generated 7 new + 650 unchanged - 3 fixed
= 657 total (was 653) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m  1s{color}
| {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  0m 12s{color} | {color:red}
metastore-common in the patch failed. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  0m 14s{color} | {color:red}
metastore-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 27s{color} |
{color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 11s{color}
| {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 20m 29s{color} | {color:black}
{color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19)
x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-22714/dev-support/hive-personality.sh
|
| git revision | master / be72da5 |
| Default Java | 1.8.0_111 |
| findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-22714/yetus/branch-findbugs-standalone-metastore_metastore-common.txt
|
| findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-22714/yetus/branch-findbugs-standalone-metastore_metastore-server.txt
|
| checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-22714/yetus/diff-checkstyle-standalone-metastore_metastore-server.txt
|
| findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-22714/yetus/patch-findbugs-standalone-metastore_metastore-common.txt
|
| findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-22714/yetus/patch-findbugs-standalone-metastore_metastore-server.txt
|
| modules | C: standalone-metastore/metastore-common standalone-metastore/metastore-server
U: standalone-metastore |
| Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-22714/yetus.txt |
| Powered by | Apache Yetus    http://yetus.apache.org |


This message was automatically generated.



> [ Interface changes ] Keep HMS interfaces backward compatible with changes for HIVE-21637
> -----------------------------------------------------------------------------------------
>
>                 Key: HIVE-22017
>                 URL: https://issues.apache.org/jira/browse/HIVE-22017
>             Project: Hive
>          Issue Type: Sub-task
>    Affects Versions: 2.3.7
>            Reporter: Daniel Dai
>            Assignee: Kishen Das
>            Priority: Major
>         Attachments: HIVE-22017.1.patch, HIVE-22017.2.patch, HIVE-22017.3.patch, HIVE-22017.4.patch,
HIVE-22017.5.patch
>
>
> As part of HIVE-21637 we would have to introduce ValidWriteIdList in several methods.
Also, in the long term, we should deprecate and remove all the methods that take direct arguments,
as the service definition keeps changing whenever we add/remove arguments, making it hard
to maintain backward compatibility. So, instead of adding writeId  in bunch of get_xxx calls
that take direct arguments, we will create new set of methods that take Request object and
return Response object. We shall mark those deprecated and remove in future version.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message