hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (Jira)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-22017) [ Interface changes ] Keep HMS interfaces backward compatible with changes for HIVE-21637
Date Wed, 03 Jun 2020 00:52:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-22017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17124486#comment-17124486
] 

Hive QA commented on HIVE-22017:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/13004657/HIVE-22017.6.patch

{color:green}SUCCESS:{color} +1 due to 2 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 6 failed/errored test(s), 17108 tests executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.ql.metadata.TestSessionHiveMetastoreClientListPartitionsTempTable.testGetPartitionsRequest[Embedded]
(batchId=269)
org.apache.hadoop.hive.ql.metadata.TestSessionHiveMetastoreClientListPartitionsTempTable.testGetPartitionsRequest[Remote]
(batchId=269)
org.apache.hadoop.hive.ql.metadata.TestSessionHiveMetastoreClientListPartitionsTempTable.testListPartitionNamesRequestByValues[Embedded]
(batchId=269)
org.apache.hadoop.hive.ql.metadata.TestSessionHiveMetastoreClientListPartitionsTempTable.testListPartitionNamesRequestByValues[Remote]
(batchId=269)
org.apache.hadoop.hive.ql.metadata.TestSessionHiveMetastoreClientListPartitionsTempTable.testListPartitionsWithAuthRequestByValues[Embedded]
(batchId=269)
org.apache.hadoop.hive.ql.metadata.TestSessionHiveMetastoreClientListPartitionsTempTable.testListPartitionsWithAuthRequestByValues[Remote]
(batchId=269)
{noformat}

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/22719/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/22719/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-22719/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 6 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 13004657 - PreCommit-HIVE-Build

> [ Interface changes ] Keep HMS interfaces backward compatible with changes for HIVE-21637
> -----------------------------------------------------------------------------------------
>
>                 Key: HIVE-22017
>                 URL: https://issues.apache.org/jira/browse/HIVE-22017
>             Project: Hive
>          Issue Type: Sub-task
>    Affects Versions: 2.3.7
>            Reporter: Daniel Dai
>            Assignee: Kishen Das
>            Priority: Major
>         Attachments: HIVE-22017.1.patch, HIVE-22017.2.patch, HIVE-22017.3.patch, HIVE-22017.4.patch,
HIVE-22017.5.patch, HIVE-22017.6.patch
>
>
> As part of HIVE-21637 we would have to introduce ValidWriteIdList in several methods.
Also, in the long term, we should deprecate and remove all the methods that take direct arguments,
as the service definition keeps changing whenever we add/remove arguments, making it hard
to maintain backward compatibility. So, instead of adding writeId  in bunch of get_xxx calls
that take direct arguments, we will create new set of methods that take Request object and
return Response object. We shall mark those deprecated and remove in future version.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message