hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <j...@apache.org>
Subject [jira] [Work logged] (HIVE-23526) Beeline may throw the misleading exception
Date Thu, 04 Jun 2020 02:17:00 GMT

     [ https://issues.apache.org/jira/browse/HIVE-23526?focusedWorklogId=441070&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-441070
]

ASF GitHub Bot logged work on HIVE-23526:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 04/Jun/20 02:16
            Start Date: 04/Jun/20 02:16
    Worklog Time Spent: 10m 
      Work Description: belugabehr commented on a change in pull request #1029:
URL: https://github.com/apache/hive/pull/1029#discussion_r434953975



##########
File path: beeline/src/java/org/apache/hive/beeline/Commands.java
##########
@@ -1063,13 +1057,17 @@ private boolean executeInternal(String sql, boolean call) {
             showRemainingLogsIfAny(stmnt);
           }
         }
+        if (rs != null) {
+          rs.close();

Review comment:
       Closing the result set can throw a `SQLException` in which case it will skip over the
`Statement#close()` method.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 441070)
    Time Spent: 3h 10m  (was: 3h)

> Beeline may throw the misleading exception
> ------------------------------------------
>
>                 Key: HIVE-23526
>                 URL: https://issues.apache.org/jira/browse/HIVE-23526
>             Project: Hive
>          Issue Type: Improvement
>          Components: Beeline
>         Environment: Hive 1.2.2
>            Reporter: Zhihua Deng
>            Priority: Minor
>              Labels: pull-request-available
>         Attachments: HIVE-23526.2.patch, HIVE-23526.3.patch, HIVE-23526.patch, outofsequence.log
>
>          Time Spent: 3h 10m
>  Remaining Estimate: 0h
>
> Sometimes we can see 'out of sequence response' message in beeline, for example:
> Error: org.apache.thrift.TApplicationException: CloseOperation failed: out of sequence
response (state=08S01,code=0)
> java.sql.SQLException: org.apache.thrift.TApplicationException: CloseOperation failed:
out of sequence response
> at org.apache.hive.jdbc.HiveStatement.closeClientOperation(HiveStatement.java:198)
> at org.apache.hive.jdbc.HiveStatement.close(HiveStatement.java:217)
> at org.apache.hive.beeline.Commands.execute(Commands.java:891)
> at org.apache.hive.beeline.Commands.sql(Commands.java:713)
> at org.apache.hive.beeline.BeeLine.dispatch(BeeLine.java:976)
> at org.apache.hive.beeline.BeeLine.execute(BeeLine.java:816)
> at org.apache.hive.beeline.BeeLine.begin(BeeLine.java:774)
> at org.apache.hive.beeline.BeeLine.mainWithInputRedirection(BeeLine.java:487)
> at org.apache.hive.beeline.BeeLine.main(BeeLine.java:470)
> and there is no other usage message to figured it out, even with --verbose, this makes
problem puzzled as beeline does not have concurrency problem on underlying thrift transport.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message