hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <j...@apache.org>
Subject [jira] [Work logged] (HIVE-23539) Optimize data copy during repl load operation for HDFS based staging location
Date Thu, 11 Jun 2020 14:45:00 GMT

     [ https://issues.apache.org/jira/browse/HIVE-23539?focusedWorklogId=444297&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-444297
]

ASF GitHub Bot logged work on HIVE-23539:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 11/Jun/20 14:44
            Start Date: 11/Jun/20 14:44
    Worklog Time Spent: 10m 
      Work Description: pkumarsinha commented on a change in pull request #1084:
URL: https://github.com/apache/hive/pull/1084#discussion_r438839329



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/bootstrap/load/table/LoadPartitions.java
##########
@@ -243,29 +246,34 @@ private void addPartition(boolean hasMorePartitions, AlterTableAddPartitionDesc
               : LoadFileType.OVERWRITE_EXISTING);
       stagingDir = PathUtils.getExternalTmpPath(replicaWarehousePartitionLocation, context.pathInfo);
     }
-
-    Task<?> copyTask = ReplCopyTask.getLoadCopyTask(
-        event.replicationSpec(),
-        new Path(event.dataPath() + Path.SEPARATOR + getPartitionName(sourceWarehousePartitionLocation)),
-        stagingDir,
-        context.hiveConf, false, false
-    );
-
+    Path partDataSrc = new Path(event.dataPath() + File.separator + getPartitionName(sourceWarehousePartitionLocation));
+    Path moveSource = performOnlyMove ? partDataSrc : stagingDir;
     Task<?> movePartitionTask = null;
     if (loadFileType != LoadFileType.IGNORE) {
       // no need to create move task, if file is moved directly to target location.
-      movePartitionTask = movePartitionTask(table, partSpec, stagingDir, loadFileType);
+      movePartitionTask = movePartitionTask(table, partSpec, moveSource, loadFileType);

Review comment:
       Path moveSource = performOnlyMove ? partDataSrc : stagingDir;
   Move src is either partDataSrc(which is repl Staging dir) or load's own local staging dir
which is used to do operation,




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 444297)
    Time Spent: 40m  (was: 0.5h)

> Optimize data copy during repl load operation for HDFS based staging location
> -----------------------------------------------------------------------------
>
>                 Key: HIVE-23539
>                 URL: https://issues.apache.org/jira/browse/HIVE-23539
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Pravin Sinha
>            Assignee: Pravin Sinha
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: HIVE-23539.01.patch
>
>          Time Spent: 40m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message