[ https://issues.apache.org/jira/browse/HIVE-23633?focusedWorklogId=444237&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-444237
]
ASF GitHub Bot logged work on HIVE-23633:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Jun/20 11:55
Start Date: 11/Jun/20 11:55
Worklog Time Spent: 10m
Work Description: dengzhhu653 commented on a change in pull request #1071:
URL: https://github.com/apache/hive/pull/1071#discussion_r438729662
##########
File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java
##########
@@ -13272,19 +13283,18 @@ public int deleteScheduledExecutions(int maxRetainSecs) {
return 0;
}
boolean committed = false;
+ Query q = null;
try {
openTransaction();
int maxCreateTime = (int) (System.currentTimeMillis() / 1000) - maxRetainSecs;
- Query q = pm.newQuery(MScheduledExecution.class);
+ q = pm.newQuery(MScheduledExecution.class);
Review comment:
Done. Thanks for the review, @kgyrtkirk. The try-with-resources exception handling
written here may not be beautiful.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 444237)
Time Spent: 50m (was: 40m)
> Metastore some JDO query objects do not close properly
> ------------------------------------------------------
>
> Key: HIVE-23633
> URL: https://issues.apache.org/jira/browse/HIVE-23633
> Project: Hive
> Issue Type: Bug
> Reporter: Zhihua Deng
> Priority: Major
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> After patched [HIVE-10895|https://issues.apache.org/jira/browse/HIVE-10895], The metastore
still has seen a memory leak on db resources: many StatementImpls left unclosed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
|