hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <j...@apache.org>
Subject [jira] [Work logged] (HIVE-23972) Add external client ID to LLAP external client
Date Sat, 01 Aug 2020 01:11:00 GMT

     [ https://issues.apache.org/jira/browse/HIVE-23972?focusedWorklogId=465236&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-465236
]

ASF GitHub Bot logged work on HIVE-23972:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 01/Aug/20 01:10
            Start Date: 01/Aug/20 01:10
    Worklog Time Spent: 10m 
      Work Description: jdere opened a new pull request #1350:
URL: https://github.com/apache/hive/pull/1350


   Change-Id: I0f8d731d478417a244abe77d087a2248e4167b90
   
   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/Hive/HowToContribute
     2. Ensure that you have created an issue on the Hive project JIRA: https://issues.apache.org/jira/projects/HIVE/summary
     3. Ensure you have added or run the appropriate tests for your PR: 
     4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]HIVE-XXXXX:  Your
PR title ...'.
     5. Be sure to keep the PR description updated to reflect all changes.
     6. Please write your PR title to summarize what this PR proposes.
     7. If possible, provide a concise example to reproduce the issue for a faster review.
   
   -->
   
   ### What changes were proposed in this pull request?
   <!--
   Please clarify what changes you are proposing. The purpose of this section is to outline
the changes and how this PR fixes the issue. 
   If possible, please consider writing useful notes for better and faster reviews in your
PR. See the examples below.
     1. If you refactor some codes with changing classes, showing the class hierarchy will
help reviewers.
     2. If you fix some SQL features, you can provide some references of other DBMSes.
     3. If there is design documentation, please add the link.
     4. If there is a discussion in the mailing list, please add the link.
   -->
   Add a HiveConf setting to include an external client ID to LLAP external client requests.
The ID is also included in the external splits so that the ID can be shown in the LLAP executorsStatus.
   
   ### Why are the changes needed?
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you propose a new API, clarify the use case for a new API.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   
   
   ### Does this PR introduce _any_ user-facing change?
   <!--
   Note that it means *any* user-facing change including all aspects such as the documentation
fix.
   If yes, please clarify the previous behavior and the change this PR proposes - provide
the console output, description, screenshot and/or a reproducable example to show the behavior
difference if possible.
   If possible, please also clarify if this is a user-facing change compared to the released
Hive versions or within the unreleased branches such as master.
   If no, write 'No'.
   -->
   
   
   ### How was this patch tested?
   <!--
   If tests were added, say they were added here. Please make sure to add some test cases
that check the changes thoroughly including negative and positive cases if possible.
   If it was tested in a way different from regular unit tests, please clarify how you tested
step by step, ideally copy and paste-able, so that other reviewers can test and check, and
descendants can verify in the future.
   If tests were not added, please describe why they were not added and/or why it was difficult
to add.
   -->
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 465236)
    Remaining Estimate: 0h
            Time Spent: 10m

> Add external client ID to LLAP external client
> ----------------------------------------------
>
>                 Key: HIVE-23972
>                 URL: https://issues.apache.org/jira/browse/HIVE-23972
>             Project: Hive
>          Issue Type: Bug
>          Components: llap
>            Reporter: Jason Dere
>            Assignee: Jason Dere
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> There currently is not a good way to tell which currently running LLAP tasks are from
external LLAP clients, and also no good way to know which application is submitting these
external LLAP requests.
> One possible solution for this is to add an option for the external LLAP client to pass
in an external client ID, which can get logged by HiveServer2 during the getSplits request,
as well as displayed from the LLAP executorsStatus.
> cc [~ShubhamChaurasia]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message