hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <j...@apache.org>
Subject [jira] [Work logged] (HIVE-23975) Reuse evicted keys from aggregation buffers
Date Mon, 03 Aug 2020 16:29:00 GMT

     [ https://issues.apache.org/jira/browse/HIVE-23975?focusedWorklogId=465792&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-465792
]

ASF GitHub Bot logged work on HIVE-23975:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 03/Aug/20 16:28
            Start Date: 03/Aug/20 16:28
    Worklog Time Spent: 10m 
      Work Description: mustafaiman commented on a change in pull request #1352:
URL: https://github.com/apache/hive/pull/1352#discussion_r464523610



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorGroupByOperator.java
##########
@@ -514,7 +526,8 @@ private void prepareBatchAggregationBufferSets(VectorizedRowBatch batch)
throws
           // is very important to clone the keywrapper, the one we have from our
           // keyWrappersBatch is going to be reset/reused on next batch.
           aggregationBuffer = allocateAggregationBuffer();

Review comment:
       @rbalamohan I have another patch for that.

##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorGroupByOperator.java
##########
@@ -514,7 +526,8 @@ private void prepareBatchAggregationBufferSets(VectorizedRowBatch batch)
throws
           // is very important to clone the keywrapper, the one we have from our
           // keyWrappersBatch is going to be reset/reused on next batch.
           aggregationBuffer = allocateAggregationBuffer();

Review comment:
       @rbalamohan I have another patch for that: https://github.com/apache/hive/pull/1337/files




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 465792)
    Time Spent: 0.5h  (was: 20m)

> Reuse evicted keys from aggregation buffers
> -------------------------------------------
>
>                 Key: HIVE-23975
>                 URL: https://issues.apache.org/jira/browse/HIVE-23975
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Mustafa Iman
>            Assignee: Mustafa Iman
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message