hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <j...@apache.org>
Subject [jira] [Work logged] (HIVE-24022) Optimise HiveMetaStoreAuthorizer.createHiveMetaStoreAuthorizer
Date Mon, 31 Aug 2020 18:28:00 GMT

     [ https://issues.apache.org/jira/browse/HIVE-24022?focusedWorklogId=476743&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-476743
]

ASF GitHub Bot logged work on HIVE-24022:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 31/Aug/20 18:27
            Start Date: 31/Aug/20 18:27
    Worklog Time Spent: 10m 
      Work Description: sam-an-cloudera commented on pull request #1385:
URL: https://github.com/apache/hive/pull/1385#issuecomment-683950735


   > @sam-an-cloudera initialValue() return type was Configuration and is now HiveConf
which is a sub-class of Configuration. Was there a reason for this change? It would be more
appropriate that the return type be Configuration. Thoughts?
   
   It was mainly to avoid having to cast. The config used in createHiveMetastoreAuthorizer(
) method is required to be a HiveConf, the createHiveAuthorizer( ) call in particular. If
we keep it as Configuration, then down there we have to do a cast, which is not good style,
so I changed the original to HiveConf. 
   
   HiveConf hiveConf = tConfig.get();
       if(hiveConf == null){
         HiveConf hiveConf1 = new HiveConf(super.getConf(), HiveConf.class); <==If I don't
change, then here would need a cast. 
         tConfig.set(hiveConf1);
         hiveConf = hiveConf1;
       }


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 476743)
    Time Spent: 0.5h  (was: 20m)

> Optimise HiveMetaStoreAuthorizer.createHiveMetaStoreAuthorizer
> --------------------------------------------------------------
>
>                 Key: HIVE-24022
>                 URL: https://issues.apache.org/jira/browse/HIVE-24022
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Rajesh Balamohan
>            Assignee: Sam An
>            Priority: Minor
>              Labels: performance, pull-request-available
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> For a table with 3000+ partitions, analyze table takes a lot longer time as HiveMetaStoreAuthorizer
tries to create HiveConf for every partition request.
>  
> [https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/metastore/HiveMetaStoreAuthorizer.java#L319]
>  
> [https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/metastore/HiveMetaStoreAuthorizer.java#L447]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message