hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <j...@apache.org>
Subject [jira] [Work logged] (HIVE-24068) Add re-execution plugin for handling DAG submission failures
Date Tue, 25 Aug 2020 07:59:00 GMT

     [ https://issues.apache.org/jira/browse/HIVE-24068?focusedWorklogId=474185&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-474185
]

ASF GitHub Bot logged work on HIVE-24068:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 25/Aug/20 07:58
            Start Date: 25/Aug/20 07:58
    Worklog Time Spent: 10m 
      Work Description: kgyrtkirk commented on a change in pull request #1428:
URL: https://github.com/apache/hive/pull/1428#discussion_r476242856



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/reexec/ReExecutionDagSubmitPlugin.java
##########
@@ -0,0 +1,86 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hive.ql.reexec;
+
+import org.apache.hadoop.hive.ql.Driver;
+import org.apache.hadoop.hive.ql.hooks.ExecuteWithHookContext;
+import org.apache.hadoop.hive.ql.hooks.HookContext;
+import org.apache.hadoop.hive.ql.hooks.HookContext.HookType;
+import org.apache.hadoop.hive.ql.plan.mapper.PlanMapper;
+import org.apache.hadoop.hive.ql.processors.CommandProcessorException;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/**
+ * Re-Executes a query when DAG submission fails after get session returned successfully.
+ */
+public class ReExecutionDagSubmitPlugin implements IReExecutionPlugin {
+
+  private static final Logger LOG = LoggerFactory.getLogger(ReExecutionDagSubmitPlugin.class);
+  class LocalHook implements ExecuteWithHookContext {
+
+    @Override
+    public void run(HookContext hookContext) throws Exception {
+      if (hookContext.getHookType() == HookType.ON_FAILURE_HOOK) {
+        Throwable exception = hookContext.getException();
+        if (exception != null) {
+          if (exception.getMessage() != null) {
+            // there could be race condition where getSession could return a healthy AM but
by the time DAG is submitted
+            // the AM could become unhealthy/unreachable (possible DNS or network issues)
which can fail tez DAG
+            // submission. Since the DAG hasn't started execution yet this failure can be
safely restarted.

Review comment:
       I think this explanation could be moved into the class documentation




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 474185)
    Time Spent: 20m  (was: 10m)

> Add re-execution plugin for handling DAG submission failures
> ------------------------------------------------------------
>
>                 Key: HIVE-24068
>                 URL: https://issues.apache.org/jira/browse/HIVE-24068
>             Project: Hive
>          Issue Type: Bug
>    Affects Versions: 4.0.0
>            Reporter: Prasanth Jayachandran
>            Assignee: Prasanth Jayachandran
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> DAG submission failure can also happen in environments where AM container died causing
DNS issues. DAG submissions are safe to retry as the DAG hasn't started execution yet. There
are retries at getSession and submitDAG level individually but some submitDAG failure has
to retry getSession as well as AM could be unreachable, this can be handled in re-execution
plugin.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message