hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <j...@apache.org>
Subject [jira] [Work logged] (HIVE-24072) HiveAggregateJoinTransposeRule may try to create an invalid transformation
Date Mon, 31 Aug 2020 17:38:00 GMT

     [ https://issues.apache.org/jira/browse/HIVE-24072?focusedWorklogId=476710&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-476710
]

ASF GitHub Bot logged work on HIVE-24072:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 31/Aug/20 17:37
            Start Date: 31/Aug/20 17:37
    Worklog Time Spent: 10m 
      Work Description: jcamachor commented on a change in pull request #1432:
URL: https://github.com/apache/hive/pull/1432#discussion_r480282656



##########
File path: ql/src/test/results/clientpositive/llap/groupby_join_pushdown.q.out
##########
@@ -644,29 +646,18 @@ STAGE PLANS:
                       Statistics: Num rows: 9173 Data size: 82188 Basic stats: COMPLETE Column
stats: COMPLETE
                       Group By Operator
                         aggregations: max(_col0)
-                        keys: _col1 (type: bigint)
-                        minReductionHashAggr: 0.49994552
+                        keys: _col1 (type: bigint), _col0 (type: int)

Review comment:
       The aggregate call column is also part of the group by key now.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 476710)
    Time Spent: 40m  (was: 0.5h)

> HiveAggregateJoinTransposeRule may try to create an invalid transformation
> --------------------------------------------------------------------------
>
>                 Key: HIVE-24072
>                 URL: https://issues.apache.org/jira/browse/HIVE-24072
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Zoltan Haindrich
>            Assignee: Zoltan Haindrich
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> {code}
> java.lang.AssertionError: 
> Cannot add expression of different type to set:
> set type is RecordType(INTEGER NOT NULL o_orderkey, DECIMAL(10, 0) o_totalprice, DATE
o_orderdate, INTEGER NOT NULL c_custkey, VARCHAR(25) CHARACTER SET "UTF-16LE" c_name, DOUBLE
$f5) NOT NULL
> expression type is RecordType(INTEGER NOT NULL o_orderkey, INTEGER NOT NULL o_custkey,
DECIMAL(10, 0) o_totalprice, DATE o_orderdate, INTEGER NOT NULL c_custkey, DOUBLE $f1) NOT
NULL
> set is rel#567:HiveAggregate.HIVE.[].any(input=HepRelVertex#490,group={2, 4, 5, 6, 7},agg#0=sum($1))
> expression is HiveProject(o_orderkey=[$2], o_custkey=[$3], o_totalprice=[$4], o_orderdate=[$5],
c_custkey=[$6], $f1=[$1])
>   HiveJoin(condition=[=($2, $0)], joinType=[inner], algorithm=[none], cost=[{2284.5 rows,
0.0 cpu, 0.0 io}])
>     HiveAggregate(group=[{0}], agg#0=[sum($1)])
>       HiveProject(l_orderkey=[$0], l_quantity=[$4])
>         HiveTableScan(table=[[tpch_0_001, lineitem]], table:alias=[l])
>     HiveJoin(condition=[=($0, $6)], joinType=[inner], algorithm=[none], cost=[{1.0000000000009115E15
rows, 0.0 cpu, 0.0 io}])
>       HiveJoin(condition=[=($4, $1)], joinType=[inner], algorithm=[none], cost=[{1650.0
rows, 0.0 cpu, 0.0 io}])
>         HiveProject(o_orderkey=[$0], o_custkey=[$1], o_totalprice=[$3], o_orderdate=[$4])
>           HiveTableScan(table=[[tpch_0_001, orders]], table:alias=[orders])
>         HiveProject(c_custkey=[$0], c_name=[$1])
>           HiveTableScan(table=[[tpch_0_001, customer]], table:alias=[customer])
>       HiveProject($f0=[$0])
>         HiveFilter(condition=[>($1, 3E2)])
>           HiveAggregate(group=[{0}], agg#0=[sum($4)])
>             HiveTableScan(table=[[tpch_0_001, lineitem]], table:alias=[lineitem])
> 	at org.apache.calcite.plan.RelOptUtil.verifyTypeEquivalence(RelOptUtil.java:383)
> 	at org.apache.calcite.plan.hep.HepRuleCall.transformTo(HepRuleCall.java:57)
> 	at org.apache.calcite.plan.RelOptRuleCall.transformTo(RelOptRuleCall.java:236)
> 	at org.apache.hadoop.hive.ql.optimizer.calcite.rules.HiveAggregateJoinTransposeRule.onMatch(HiveAggregateJoinTransposeRule.java:300)
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message