From issues-return-199739-apmail-hive-issues-archive=hive.apache.org@hive.apache.org Thu Oct 1 12:30:03 2020 Return-Path: X-Original-To: apmail-hive-issues-archive@locus.apache.org Delivered-To: apmail-hive-issues-archive@locus.apache.org Received: from mxout1-he-de.apache.org (mxout1-he-de.apache.org [95.216.194.37]) by minotaur.apache.org (Postfix) with ESMTP id 808411A0E7 for ; Thu, 1 Oct 2020 12:30:03 +0000 (UTC) Received: from mail.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mxout1-he-de.apache.org (ASF Mail Server at mxout1-he-de.apache.org) with SMTP id 78AF663997 for ; Thu, 1 Oct 2020 12:30:02 +0000 (UTC) Received: (qmail 9688 invoked by uid 500); 1 Oct 2020 12:30:01 -0000 Delivered-To: apmail-hive-issues-archive@hive.apache.org Received: (qmail 9656 invoked by uid 500); 1 Oct 2020 12:30:01 -0000 Mailing-List: contact issues-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list issues@hive.apache.org Received: (qmail 9645 invoked by uid 99); 1 Oct 2020 12:30:01 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 Oct 2020 12:30:01 +0000 Received: from jira-he-de.apache.org (static.172.67.40.188.clients.your-server.de [188.40.67.172]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 01C374048D for ; Thu, 1 Oct 2020 12:30:01 +0000 (UTC) Received: from jira-he-de.apache.org (localhost.localdomain [127.0.0.1]) by jira-he-de.apache.org (ASF Mail Server at jira-he-de.apache.org) with ESMTP id 73C09780124 for ; Thu, 1 Oct 2020 12:30:00 +0000 (UTC) Date: Thu, 1 Oct 2020 12:30:00 +0000 (UTC) From: "ASF GitHub Bot (Jira)" To: issues@hive.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Work logged] (HIVE-20137) Truncate for Transactional tables should use base_x MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-20137?focusedWorklogId=3D= 493464&page=3Dcom.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpa= nel#worklog-493464 ] ASF GitHub Bot logged work on HIVE-20137: ----------------------------------------- Author: ASF GitHub Bot Created on: 01/Oct/20 12:29 Start Date: 01/Oct/20 12:29 Worklog Time Spent: 10m=20 Work Description: pvargacl commented on a change in pull request #153= 2: URL: https://github.com/apache/hive/pull/1532#discussion_r498204987 ########## File path: ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java ########## @@ -114,16 +114,16 @@ public class AcidUtils { // This key will be put in the conf file when planning an acid operation public static final String CONF_ACID_KEY =3D "hive.doing.acid"; - public static final String BASE_PREFIX =3D "base_"; + public static final String BASE_PREFIX =3D AcidConstants.BASE_PREFIX; Review comment: I am not sure I want to remove these public constants, the AcidUtils= is unfortunately is being used by spark-acid and it might break compatibil= ity... ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 493464) Time Spent: 40m (was: 0.5h) > Truncate for Transactional tables should use base_x > --------------------------------------------------- > > Key: HIVE-20137 > URL: https://issues.apache.org/jira/browse/HIVE-20137 > Project: Hive > Issue Type: Improvement > Components: Transactions > Affects Versions: 3.0.0 > Reporter: Eugene Koifman > Assignee: Peter Varga > Priority: Major > Labels: pull-request-available > Time Spent: 40m > Remaining Estimate: 0h > > This is a follow up to=C2=A0HIVE-19387. > Once we have a lock that blocks writers but not readers (HIVE-19369), it = would make sense to make truncate create a new base_x, where is x is a writ= eId in current txn - the same as Insert Overwrite does. > This would mean it can work w/o interfering with existing writers. -- This message was sent by Atlassian Jira (v8.3.4#803005)